updated controller-runtime #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed controller-filtered cache fixed make bundle not generating alm-examples because the sample did not match the apiVersion needed to comment out the removing secret and apiservice temporarily to avoid caching those resources Signed-off-by: Henry H Li <henry.h.li@ibm.com>
- APIService was something created before the cert-manager v1 migration - will never exist in fresh install - in upgrade scenarios, users must be running at least 3.19.9, which means APIService would have been removed already Signed-off-by: Henry H Li <henry.h.li@ibm.com>
- because the old code was only concerned about checking if the pre v1 cert-manager annotation was there, but what actually matters is if the v1 annotation exists or not - by deleting the old webhook secret if it does not contain the correct annotation (cert-manager.io/allow-direct-injection) - also not setting up the cache for secrets at all to avoid overhead and directly reading from API server since this is infrequently invoked code Signed-off-by: Henry H Li <henry.h.li@ibm.com>
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
|
Built image locally, deployed to my 4.2 environment, scaled it down, deleted operands, scaled it up, operands redeployed as expected. Going to approve and merge |
|
/lgtm |
bluzarraga
approved these changes
Oct 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitscuit, bluzarraga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed make bundle not generating alm-examples because the sample did not match the apiVersion
needed to comment out the removing secret and apiservice temporarily to avoid caching those resources
How to test
Not much to do, just ensure it can deploy the operands successfully