Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated controller-runtime #373

Merged
merged 5 commits into from
Oct 13, 2023
Merged

updated controller-runtime #373

merged 5 commits into from
Oct 13, 2023

Commits on Oct 5, 2023

  1. updated controller-runtime 

    - removed controller-filtered cache

fixed make bundle not generating alm-examples because the sample did not
match the apiVersion

needed to comment out the removing secret and apiservice temporarily to
avoid caching those resources

Signed-off-by: Henry H Li <henry.h.li@ibm.com>
    @bitscuit
    bitscuit committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ac24f07 View commit details
    Browse the repository at this point in the history

  2. removed removeAPIService because unlikely to eixst 

    - APIService was something created before the cert-manager v1 migration
- will never exist in fresh install
- in upgrade scenarios, users must be running at least 3.19.9, which
  means APIService would have been removed already

Signed-off-by: Henry H Li <henry.h.li@ibm.com>
    @bitscuit
    bitscuit committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7d099f3 View commit details
    Browse the repository at this point in the history

  3. changed removeOldSecret to be more robust 

    - because the old code was only concerned about checking if the pre v1
  cert-manager annotation was there, but what actually matters is if the
v1 annotation exists or not
- by deleting the old webhook secret if it does not contain the correct
  annotation (cert-manager.io/allow-direct-injection)
- also not setting up the cache for secrets at all to avoid overhead and
  directly reading from API server since this is infrequently invoked
code

Signed-off-by: Henry H Li <henry.h.li@ibm.com>
    @bitscuit
    bitscuit committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3ee95d6 View commit details
    Browse the repository at this point in the history

  4. removed APIService from cache 

    Signed-off-by: Henry H Li <henry.h.li@ibm.com>
    @bitscuit
    bitscuit committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5a8832a View commit details
    Browse the repository at this point in the history

  5. removed unused secretshare-operator code 

    Signed-off-by: Henry H Li <henry.h.li@ibm.com>
    @bitscuit
    bitscuit committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b69df38 View commit details
    Browse the repository at this point in the history