Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer group incorrectly omits members (without any assigned partitions) from SyncGroup requests #2290

Closed
dnwe opened this issue Jul 22, 2022 · 0 comments · Fixed by #2292

Comments

@dnwe
Copy link
Collaborator

dnwe commented Jul 22, 2022

Problem Description

Kafka outputs a warning here when a SyncGroup request is received from the group leader that doesn't contain all of the members that were present in the original JoinGroup requests. This doesn't seem to cause any actual issue on the broker, but does cause unnecessary noise in the logs that it would be good to silence.

This can happen in Sarama if the number of consumers/members exceeds the number of available partitions for a given topic and so one or more members are not assigned any partitions as part of the plan. When this occurs we omit them from the SyncGroup request, but we should instead be including them in the consumer group metadata member assignments, but with an empty member assignment

dnwe added a commit that referenced this issue Jul 22, 2022
- comment and rework sync_group_{request, response}
- always send V3 SyncGroup request if config Version is 2.3.0.0 or newer
- when sending SyncGroup as the leader, include empty assignments for
  any members that didn't receive a partition in the plan
- update go.mod/go.sum for examples/consumergroup

Fixes #2290
k-wall pushed a commit to k-wall/sarama that referenced this issue Nov 23, 2022
- comment and rework sync_group_{request, response}
- always send V3 SyncGroup request if config Version is 2.3.0.0 or newer
- when sending SyncGroup as the leader, include empty assignments for
  any members that didn't receive a partition in the plan
- update go.mod/go.sum for examples/consumergroup

Fixes IBM#2290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant