Implements v1 of {Create,Describe,Delete}AclRequest #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mongey
force-pushed
the
cm-v1-create-acl-request
branch
from
c23fdee
to
e8436b8
Compare
Mongey
changed the title
varun06
reviewed
Feb 19, 2019
acl_create_request.go
Outdated
| @@ -1,6 +1,7 @@ | |||
| package sarama | |||
|
|
|||
| type CreateAclsRequest struct { | |||
| Version int | |||
There was a problem hiding this comment.
Does Version has to be int, if we are casting it to/fro int16?
varun06
reviewed
Feb 19, 2019
Mongey
force-pushed
the
cm-v1-create-acl-request
branch
from
97d687c
to
2082771
Compare
Mongey
force-pushed
the
cm-v1-create-acl-request
branch
from
2082771
to
66abce6
Compare
|
It seems that the ClusterAdmin interface is not updated to cover the prefixed resources. The ListAcls method does not take a version argument. Thus, it creates a DescribeAclsRequest struct with no version defined and this defaults to V0_11_0_0. Or do I miss something here? Let me know, I am happy to submit a PR for this. thanks! |
|
Opened an issue: #1451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.