Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): permit AlterConfigsRequest V1 #2550

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Aug 3, 2023

This is identical in format to V0, but just influences the broker's response behaviour

Contributes-to: #2408

Add a test to ensure that the requiredVersion of the request and
response pairs matches. Accordingly fix DescribeConfigs which had a
V1_0_0_0 instead of V1_1_0_0 bug for V1 in the Response

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This is identical in format to V0, but just influences the broker's
response behaviour:
> starting in version 1, on quota violation, brokers send out responses
> before throttling.

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This is identical in format to V0, but just influences the broker's response behaviour

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe force-pushed the dnwe/alter-configs-request-v1 branch from c01e9cf to 47c47ae Compare August 3, 2023 13:36
Copy link
Collaborator

@hindessm hindessm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from dnwe/create-partitions-v1 to main August 3, 2023 13:43
@dnwe dnwe merged commit 6010af0 into main Aug 3, 2023
17 checks passed
@dnwe dnwe deleted the dnwe/alter-configs-request-v1 branch August 3, 2023 13:51
@dnwe dnwe added fix feat and removed fix labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants