Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(proto): permit AlterConfigsRequest V1 #2550

Merged
merged 3 commits into from
Aug 3, 2023
Merged

chore(proto): permit AlterConfigsRequest V1 #2550

merged 3 commits into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. fix(proto): ensure req+resp requiredVersion match 

    Add a test to ensure that the requiredVersion of the request and
response pairs matches. Accordingly fix DescribeConfigs which had a
V1_0_0_0 instead of V1_1_0_0 bug for V1 in the Response

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7ed263c View commit details
    Browse the repository at this point in the history

  2. chore(proto): permit CreatePartitionsRequest V1 

    This is identical in format to V0, but just influences the broker's
response behaviour:
> starting in version 1, on quota violation, brokers send out responses
> before throttling.

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c4255f4 View commit details
    Browse the repository at this point in the history

  3. chore(proto): permit AlterConfigsRequest V1 

    This is identical in format to V0, but just influences the broker's response behaviour

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    @dnwe
    dnwe committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    47c47ae View commit details
    Browse the repository at this point in the history