Consumer: fix possible tight loop #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases the `subscriptionManager` and drain loop in `abort` could start spinning against each other for a non-trivial amount of time, if e.g. a partition was suspended waiting for the user to consume its buffer. The tight loop has always been there, it has just tended to be trivially short in normal operation so nobody noticed. This is the same issue that the `wait` channel was introduced to solve for the `subscriptionConsumer` so solve it the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases the
subscriptionManagerand drain loop inabortcould startspinning against each other for a non-trivial amount of time, if e.g. a
partition was suspended waiting for the user to consume its buffer. The tight
loop has always been there, it has just tended to be trivially short in normal
operation so nobody noticed.
This is the same issue that the
waitchannel was introduced to solve for thesubscriptionConsumerso solve it the same way.Fixes #692 cc @josselin-c