Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer: fix possible tight loop #693

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Consumer: fix possible tight loop #693

merged 1 commit into from
Jul 5, 2016

Commits on Jul 5, 2016

  1. Consumer: fix possible tight loop 

    In certain cases the `subscriptionManager` and drain loop in `abort` could start
spinning against each other for a non-trivial amount of time, if e.g. a
partition was suspended waiting for the user to consume its buffer. The tight
loop has always been there, it has just tended to be trivially short in normal
operation so nobody noticed.

This is the same issue that the `wait` channel was introduced to solve for the
`subscriptionConsumer` so solve it the same way.
    @eapache
    eapache committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    d41f123 View commit details
    Browse the repository at this point in the history