-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all suitable settings to CBA Settings #36
Conversation
…ate and update modules for new functions, Add getAllRadios API function (with caching), Move CBA settings to API component
This sounds like it is moving along. Keep me posted on testing. |
This has nothing to do with C++ side, the commits show up because it's based on #33. Not sure if this is viable yet, will decide once this is fully tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't scope away the modules for now.
class GVAR(basicMissionSetup) : Module_F { | ||
scope = 2; | ||
scope = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would disagree with hiding the modules for now. As they are pretty intuitive for most mission makers
class GVAR(DifficultySettings) : Module_F { | ||
scope = 2; | ||
scope = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing again with hiding the module
What is the decision here moving forward with modules? Should we get a dev build out soon and testing these things? Also backwards compatibility is big, so we gotta make sure that this isn't going to break old missions that use or rely on modules for core functionality. |
CBA 3.1 will have some new events that were designed to help with backwards compatibility for ace modules/settings which will be going through the same transition problems. Modules should be able to add event handler for |
From what I understand Jonpas is planning to do some further experimentation here, Modules that effect the mission settings would a nice method. |
Yes, no point discussing anything until I do more work on that. |
I will extract all fixes and improvements from this PR into a separate one. |
When merged this pull request will:
ACRE_DEPRECATED
macro.acre_api_fnc_getAllRadios
function (with caching) that returns all radios inCfgAcreRadios
in format[ ["class1", "class2",], ["name1", "name"] ]
(can easily be expanded for more information.disableSignalLoss
function.Requires #33 due to CBA settings preparation being there!
"Name Channels" module was not converted as it's designed so multiple of them can be placed to configure each side. That can be moved to Eden attributes one day when we have a nice framework for that maybe.