Rework Settings #437
Merged
Rework Settings #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this done? |
|
Should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion acemod/ACE3#4024 (comment)
For global settings, if the setting is forced by mission and not by server, then the mission setting will be used..
Adds called events
CBA_beforeSettingsInitializedandCBA_settingsInitializedAdds listen event
CBA_settings_setSettingMissionThese will allow reading of modules for ace, which should allow us to keep backwards compatibility.
The basic flow would be at
CBA_beforeSettingsInitializedwe could read settings from modules and set them as mission settings.For global settings priority would be