Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert finger to cba settings #4024

Closed
wants to merge 2 commits into from
Closed

convert finger to cba settings #4024

wants to merge 2 commits into from

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jun 29, 2016

When merged this pull request will:

  • title

@commy2 commy2 added this to the 3.7.0 milestone Jun 29, 2016
@PabstMirror
Copy link
Contributor

image

@commy2 - Based on what i'm seeing, I can't set these settings at the mission level because they are global, and global only works with server settings?

I think we would want to switch cba's get to logic like this:

if (([_setting, "mission"] call FUNC(isForced)) && {!([_setting, "server"] call FUNC(isForced))}) then {
    _value = [_setting, "mission"] call FUNC(get);
} else {
    _value = [_setting, "server"] call FUNC(get);
};

So we can force global settings at either the server or mission level.

@commy2
Copy link
Contributor Author

commy2 commented Jul 7, 2016

I think we would want to switch cba's get to logic like this

Wouldn't that mean that not-global settings are always server forced if they are not mission forced?

I think to fix this we should make isForced report false for "server" as default for isGlobal-type settings if the setting is forced by the mission.

@thojkooi thojkooi modified the milestones: 3.7.0, 3.8.0 Sep 4, 2016
@thojkooi thojkooi modified the milestones: 3.8.0, CBA Settings Oct 1, 2016
@commy2 commy2 closed this Dec 18, 2017
@commy2 commy2 deleted the settings-finger branch December 18, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants