Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignored acoustical_simulation_3d #251

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Fix ignored acoustical_simulation_3d #251

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d7bbc7
fixed ignored acoustical_simulation_3d
faberno Oct 1, 2023
f1dcff0
Merge branch 'develop' into 223-FixAcousticSimulation3D
kdreher Jun 17, 2024
e8ad060
Merge branch 'develop' into 223-FixAcousticSimulation3D
kdreher Jul 29, 2024
6eff225
fixed 3D ignore bug
kdreher Aug 13, 2024
8ce0977
fix 3d Tag not being in settings
kdreher Aug 13, 2024
d261ab3
Merge branch 'develop' into 223-FixAcousticSimulation3D
kdreher Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...core/simulation_modules/acoustic_forward_module/acoustic_forward_module_k_wave_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ def k_wave_acoustic_forward_model(self, detection_geometry: DetectionGeometryBas
field_of_view = pa_device.get_field_of_view_mm()
detector_positions_mm = pa_device.get_detector_element_positions_accounting_for_device_position_mm()

if not self.component_settings.get(Tags.ACOUSTIC_SIMULATION_3D):
acoustic_simulation_3d = False
if Tags.ACOUSTIC_SIMULATION_3D in self.component_settings:
acoustic_simulation_3d = self.component_settings[Tags.ACOUSTIC_SIMULATION_3D]
if not acoustic_simulation_3d:
detectors_are_aligned_along_x_axis = np.abs(field_of_view[2] - field_of_view[3]) < 1e-5
detectors_are_aligned_along_y_axis = np.abs(field_of_view[0] - field_of_view[1]) < 1e-5
if detectors_are_aligned_along_x_axis or detectors_are_aligned_along_y_axis:
Expand Down
Loading