Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style: lack of Java generics causes 100s of type safety warnings #2574

Closed
bencomp opened this issue Sep 23, 2015 · 3 comments
Closed

Code style: lack of Java generics causes 100s of type safety warnings #2574

bencomp opened this issue Sep 23, 2015 · 3 comments

Comments

@bencomp
Copy link
Contributor

bencomp commented Sep 23, 2015

Following up on #775. The style guide says to use Java 7 and the generics provided by the language.

This should result in 100s fewer compiler warnings about unchecked conversions and unchecked method invocations and cleaner code, e.g. because casts are no longer needed.

@bencomp
Copy link
Contributor Author

bencomp commented Oct 15, 2015

In the IRC channel @pdurbin and I discussed the possibility of allowing project settings related to NetBeans hints in the repository. Having hints for Javac compiler warnings could help enormously in getting the message of this issue across. I created #2644 for this.

@pdurbin
Copy link
Member

pdurbin commented Jun 20, 2017

I implemented this in 6535d9d and am closing this issue in favor of #3418.

@bencomp
Copy link
Contributor Author

bencomp commented Jun 21, 2017

I believe this issue was about the existence of "ugly" code, not about the dev guide. Yes, the coding style guidelines should include a guideline on the use of generics, but to solve my original issue I would have liked to see cleaning up. @oscardssmith seems to have noticed the same in #3902, so I won't ask to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants