-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code style: lack of Java generics causes 100s of type safety warnings #2574
Milestone
Comments
bencomp
added a commit
to bencomp/dataverse
that referenced
this issue
Sep 24, 2015
bencomp
added a commit
to bencomp/dataverse
that referenced
this issue
Sep 24, 2015
bencomp
added a commit
to bencomp/dataverse
that referenced
this issue
Sep 24, 2015
bencomp
added a commit
to bencomp/dataverse
that referenced
this issue
Sep 25, 2015
This was referenced Jan 12, 2016
mheppler
added
Component: Documentation
Component: Code Infrastructure
formerly "Feature: Code Infrastructure"
labels
Jan 28, 2016
pdurbin
removed
the
Component: Code Infrastructure
formerly "Feature: Code Infrastructure"
label
Jun 13, 2017
Closed
pdurbin
added a commit
that referenced
this issue
Jun 20, 2017
This was referenced Jun 20, 2017
Merged
I believe this issue was about the existence of "ugly" code, not about the dev guide. Yes, the coding style guidelines should include a guideline on the use of generics, but to solve my original issue I would have liked to see cleaning up. @oscardssmith seems to have noticed the same in #3902, so I won't ask to reopen this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following up on #775. The style guide says to use Java 7 and the generics provided by the language.
This should result in 100s fewer compiler warnings about unchecked conversions and unchecked method invocations and cleaner code, e.g. because casts are no longer needed.
The text was updated successfully, but these errors were encountered: