Fix some raw type references #2589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -489,7 +489,7 @@ public String getSolrSchema() { | |||
| sb.append(" <field name=\"" + nameSearchable + "\" type=\"" + type + "\" multiValued=\"" + multivalued + "\" stored=\"true\" indexed=\"true\"/>\n"); | |||
| } | |||
|
|
|||
| List<String> listOfStaticFields = new ArrayList(); | |||
| List<String> listOfStaticFields = new ArrayList<>(); | |||
There was a problem hiding this comment.
@bencomp you're certainly right that this is a type safety issue but the default settings from Netbeans apparently don't provide developers the typical yellow warning indicators:
If you could please share the Netbeans settings you are using, I'd appreciate it. You could even add it to the Google Doc linked from http://guides.dataverse.org/en/latest/developers/coding-style.html
|
@bencomp please see my comments about closing pull requests made against the 4.3 branch at #2860 (comment) (Let's discuss in one place, there.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to get the number of Java compiler warnings about unchecked references and casts (see #2574) I added diamonds to a few classes.
This is work in progress.