Contact/Support Form - "From" email field weirdness

[mheppler]

While reviewing recent email-related issues #1916 and #4580, I discovered a strange pattern where emails were being sent with the "from" set as the system email and in at beginning of the message body, "From: {user entered email address}" was added. (See commit 6678f44)

In my inbox, I found 5 RT tickets from the last year that illustrate this issue: 260254, 256673, 256284, 250916, 248707.

Those RT tickets show that the user-entered emails did not pass the EMAIL_PATTERN check in MailServiceBean.java, whether it was because of white space not being trimmed (260254, 256673), or the email domains not following the expected pattern (256284, 250916, 248707). Because these perfectly valid email addresses fail this backend validation check, the emails get sent off not with the user entered email address as the "from", but instead the system email is used in it's place.

This should be fixed, as it results in our support team needing to manually copy the email address from the body of the message, in order to reply directly to the user. It can unfortunately result in support responses never getting to the user.

Many thank you's to @kcondon and @pdurbin for helping to identify the cause of issue. We should confirm with @scolapasta about this EMAIL_PATTERN functionality, as it was his commit d05999a originally, in which he added "temp fix" to his comment.

As @kcondon pointed out to me, this same white space issue was originally discovered in #3044 and fixed, but only in the forms users are entering emails which are saved to the database, and not for the contact/support forms in the popups that shoot out emails.

[pdurbin]

@sekmiller incorporated a bit of feedback from me into pull request #4636 and it's looking good. I put it in QA at https://waffle.io/IQSS/dataverse

[mheppler]

@sekmiller I also added my $0.02 of a code review to a comment in the PR which should be addressed before QA picks it up. Phil is just too quick for me on the Code Review draw. (I need to start coming in earlier...)