4601 email contact issues #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
requested changes
May 1, 2018
| if (s == null) { | ||
| return false; | ||
| } | ||
| return EMAIL_PATTERN.matcher(s).matches(); |
There was a problem hiding this comment.
Can we delete EMAIL_PATTERN in StringUtil.java?
pdurbin
approved these changes
May 1, 2018
mheppler
reviewed
May 1, 2018
| @@ -37,6 +37,11 @@ public void testIsEmailValid() { | |||
| assertEquals(false, EMailValidator.isEmailValid("dora@.com", null)); | |||
| assertEquals(false, EMailValidator.isEmailValid("", null)); | |||
| assertEquals(false, EMailValidator.isEmailValid(null, null)); | |||
| /* | |||
| Add tests for 4601 | |||
There was a problem hiding this comment.
We should reformat this emails in the test to be a little less "real".
There was a problem hiding this comment.
I added a couple that came directly from the RT tickets referenced in the issue (that are now passing validation). What else did you have in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist