Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long (e.g. SHA-512) fixity checksums are too long for display #5210

Closed
qqmyers opened this issue Oct 17, 2018 · 8 comments · Fixed by #7312
Closed

Long (e.g. SHA-512) fixity checksums are too long for display #5210

qqmyers opened this issue Oct 17, 2018 · 8 comments · Fixed by #7312

Comments

@qqmyers
Copy link
Member

qqmyers commented Oct 17, 2018

File checksums are shown in multiple places and long ones (sha-512 and sha-256 in some places) will either be cut-off or run past the edge of their container. They also clutter the dataset file table. I'll submit a PR that adds wrapping where needed and replaces the main file table display checksums with small buttons showing the algorithm name in a small button that will copy the checksum value to the clipboard (with a tooltip that shows the value as well).

@qqmyers
Copy link
Member Author

qqmyers commented Oct 17, 2018

In most places, this PR just wraps the long checksum, e.g.
image

On the main dataset display, it uses the copy clipboard javascript that was already in Dataverse to make a simple button:

image

The pop-up tooltip still shows the checksum value and clicking the button copies the value to the clipboard.

Other displays that are updated by the style changes include the file page, the edit files tables, the version difference display, and the replace file display.

@mheppler
Copy link
Contributor

Whoa. That's certainly an unruly text string that taxes the limits of our file table UI. I'm going to take a look here at the UI component used and consider some options. With the proximity to the file tag UI label components (e.g. "Documentation" in the second screenshot), I am concerned that it is so visually similar to it's neighbor.

@qqmyers
Copy link
Member Author

qqmyers commented Oct 18, 2018

Since no one is going to look at that and say 'Yeah, looks right' it might be something that could always be hidden by some sort of copy button...

@oscardssmith
Copy link
Contributor

This talk is probably worth looking into. It's from defcon and is about making it easier for users to do visual checks of hash functions by displaying them as sentences or other easier to memorize chunks. https://youtu.be/xneBjc8z0DE?t=2469

@mheppler
Copy link
Contributor

Just to update on the progress: got this branch built locally, and plan to iterate on some UI tweaks, as well as demo this week for some team members to get their feedback.

@djbrooke
Copy link
Contributor

Hey @qqmyers - this is definitely an issue, but instead of taking this PR through our regular process and making this small change, this is something that we'd like to consider as part of the larger file and redesign effort in #3404. I'm going to close out the PR with a note that we won't merge this to the develop branch right now.

@djbrooke
Copy link
Contributor

Closing out this unique issue as we'll be addressing this as part of the dataset redesign in #3404.

@pdurbin
Copy link
Member

pdurbin commented Jul 18, 2019

@qqmyers I just wanted to let you know that I gave your solution a shout out yesterday at https://groups.google.com/d/msg/dataverse-community/btZ3XSryJdM/ofDUbkzcDQAJ 😄

I had forgotten about this issue or I would have linked to it. 😄

mheppler added a commit that referenced this issue Jan 8, 2021
mheppler added a commit that referenced this issue Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants