Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5210 - display long checksums #5211

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 17, 2018

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

coveralls commented Oct 17, 2018

Coverage Status

Coverage decreased (-0.001%) to 15.584% when pulling ed5999b on QualitativeDataRepository:5210-Long_checksum_display into 0107a4c on IQSS:develop.

@qqmyers
Copy link
Member Author

qqmyers commented Oct 18, 2018

Initial commit caused the same issue as in #4967 and#4838. Was able to move jsf:rendered to outer div to avoid putting it on the buttons.

@djbrooke
Copy link
Contributor

Closing this PR. I left a note in #5210 with a note that we'd like to address this as part of a larger change in #3404.

@djbrooke djbrooke closed this Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants