-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for entered coordinate values in Geospatial metadata #10142
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@stevenwinship It is because of this line: it should not default to Thinking about it though, it may have been a misguided idea, to continue allowing users to leave some of the values empty. It may be making the whole thing even more confusing than it already is. So, I suggest that we handle it as follows:
in other words, the following should be allowed: i.e., Just to be a boring nerd, the rationale is that the above (which is roughly the spot of our office at IQSS) is a fairly valid "box". Because |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…r the entry form + extra formatting for display. #9547
This comment has been minimized.
This comment has been minimized.
…m/IQSS/dataverse into 9547-validate-geospatial-metadata
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
@stevenwinship and everybody We reindexed our prod. catalogue from scratch after the last deployment (6.0), with a new version of Solr installed (older versions were less picky about these bboxes being correctly defined). We discovered in the process that we had a few thousand automatically-generated datasets that had the North/South values swapped, and they all just quietly disappeared from the search catalog. I'm going to declare this PR merged and done for real now. |
"Prod. catalogue" is Harvard Dataverse right, and the thousand automatically-generated datasets are datasets published in Harvard Dataverse? If so, what does it mean that datasets disappeared from the catalog? Sounds like they're not searchable anymore 😬 |
@jggautier There was a very long slack thread about the whole disaster, I'll look it up.
|
Thanks. And sorry; I try to keep up with the conversation. Sometimes things go over my head |
What this PR does / why we need it: Prevents the user input of invalid geospatial bounding box coordinates
Which issue(s) this PR closes: #9547
Closes #9547
Special notes for your reviewer:
Suggestions on how to test this: try adding non numbers/null values and values outside the norm for coordinates
Does this PR introduce a user interface change? If mockups are available, please link/include them here: error messages were added
Is there a release notes update needed for this change?: No
Additional documentation: