-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Computational backend: connect to resource tracking via RabbitMQ (🗃️, ⚠️) #4570
✨ Computational backend: connect to resource tracking via RabbitMQ (🗃️, ⚠️) #4570
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4570 +/- ##
========================================
- Coverage 84.5% 79.4% -5.1%
========================================
Files 1040 903 -137
Lines 44269 37500 -6769
Branches 1013 960 -53
========================================
- Hits 37416 29802 -7614
- Misses 6635 7491 +856
+ Partials 218 207 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3e21496
to
c15ba73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tldr
green light for the ops changes thanks a lot for the nice summary in the PR text :--)
...re_postgres_database/migration/versions/afc752d10a6c_add_waiting_for_resources_enum_field.py
Show resolved
Hide resolved
4136666
to
51db626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! 👍
2118c87
to
99698ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking aloud
If we want to be fully transparent with env and avoid implicit defaults (in code), then we want to have no defaults in code and provide values transparently via .env
files 🤔
*I am still not sure if we want to go in this direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider my comments regarding the moving of some code.
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/base_scheduler.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/base_scheduler.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/base_scheduler.py
Show resolved
Hide resolved
7c61686
to
9940197
Compare
8a54c13
to
3a296eb
Compare
Code Climate has analyzed commit 3a296eb and detected 0 issues on this pull request. View more on Code Climate. |
SonarCloud Quality Gate failed.
|
What do these changes do?
This PR let now the director-v2 send messages when computational services are started/stopped and while they are running (heartbeat concept)
SERVICE_TRACKING_HEARTBEAT
in date time format, defines the interval with which a heartbeat is sent into RabbitMQ while a computational service is running defaults to 60 seconds, this ENV is global as it will be used in other services (such as RUTH)last_heartbeat
,created
,modified
timestampsvarious:
Related issue/s
How to test
DevOps Checklist