♻️ Maintenance: reduce code duplication

[pcrespov]

What do these changes do?

The purpose of this PR is to remove some of the duplication reported by sonarcloud after PR #4973.

The duplication is removed by moving duplicated parts from services to the libraries. Specifically we move:

• Default API error model schema to models_library.api_schemas__common/errors.DefaultApiError
• Tools to create httpx clients and set up in an app to servicelib.fastapi.http_client
• Tools to handle exceptions to: servicelib.fastapi.exceptions_utils
• Common parts for application settings to settings_library.application
• Function duplication in simcore_service_webserver.wallets.payments_handlers

NOTE that I only changed payments, webserver and dynamic-scheduler services. Other services might also need to be refactored. I propose that every service owner will follow up on his corresponding service.

Related issue/s

• https://sonarcloud.io/component_measures?id=ITISFoundation_osparc-simcore&pullRequest=4979&metric=new_duplicated_lines_density&view=list

How to test

Add tests for new modules

• packages/models-library/tests/test_api_schemas__common.py
• packages/service-library/tests/fastapi/test_exceptions_utils.py
• `packages/settings-library/src/settings_library/application.py

DevOps

None

[codecov]

Codecov Report

Merging #4982 (65b8dd4) into master (a4002f4) will decrease coverage by 0.1%.
The diff coverage is 98.6%.

@@           Coverage Diff            @@
##           master   #4982     +/-   ##
========================================
- Coverage    86.8%   86.7%   -0.1%     
========================================
  Files        1239    1157     -82     
  Lines       51114   49459   -1655     
  Branches     1078     941    -137     
========================================
- Hits        44398   42917   -1481     
+ Misses       6479    6333    -146     
+ Partials      237     209     -28     

Flag	Coverage Δ
integrationtests	54.1% <14.2%> (-10.8%)	⬇️
unittests	84.9% <98.6%> (+0.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...y/src/models_library/api_schemas__common/errors.py	100.0% <100.0%> (ø)
...library/api_schemas_directorv2/dynamic_services.py	96.6% <100.0%> (ø)
...emas_resource_usage_tracker/credit_transactions.py	96.0% <100.0%> (-0.2%)	⬇️
...pi_schemas_resource_usage_tracker/pricing_plans.py	100.0% <100.0%> (ø)
...api_schemas_resource_usage_tracker/service_runs.py	100.0% <100.0%> (ø)
...-library/src/models_library/api_schemas_storage.py	89.5% <100.0%> (ø)
...y/src/models_library/api_schemas_webserver/auth.py	100.0% <100.0%> (ø)
...dels_library/api_schemas_webserver/computations.py	100.0% <100.0%> (ø)
...src/models_library/api_schemas_webserver/groups.py	95.3% <100.0%> (ø)
...rc/models_library/api_schemas_webserver/product.py	100.0% <100.0%> (ø)
... and 14 more

... and 119 files with indirect coverage changes

[sanderegg]

Very good! thanks a lot for this cleanup action!

[codeclimate]

Code Climate has analyzed commit 65b8dd4 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.6% Duplication

[bisgaard-itis]

Looks good to me. Thanks