Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Removes respx library from base requirements listing (fastapi.in) #5003

Merged
merged 9 commits into from
Nov 9, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 8, 2023

What do these changes do?

Related issue/s

How to test

  • adds a test that check for some common test libraries

DevOps

None

@pcrespov pcrespov requested a review from sanderegg as a code owner November 8, 2023 22:01
@pcrespov pcrespov self-assigned this Nov 8, 2023
@pcrespov pcrespov added this to the 7peaks milestone Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5003 (9a55d54) into master (da3e254) will decrease coverage by 0.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5003     +/-   ##
========================================
- Coverage    87.2%   86.8%   -0.5%     
========================================
  Files        1244     998    -246     
  Lines       51145   43016   -8129     
  Branches     1081     554    -527     
========================================
- Hits        44632   37343   -7289     
+ Misses       6275    5545    -730     
+ Partials      238     128    -110     
Flag Coverage Δ
integrationtests 63.6% <ø> (-1.3%) ⬇️
unittests 84.2% <100.0%> (-0.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lusters_keeper/modules/clusters_management_task.py 100.0% <100.0%> (ø)

... and 256 files with indirect coverage changes

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@pcrespov pcrespov enabled auto-merge (squash) November 8, 2023 22:17
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link

codeclimate bot commented Nov 9, 2023

Code Climate has analyzed commit 9a55d54 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@pcrespov pcrespov merged commit b766776 into ITISFoundation:master Nov 9, 2023
@pcrespov pcrespov deleted the fix/respx-in-base branch November 9, 2023 11:56
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants