Pso optimizer #38
Closed
Pso optimizer #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSashka
requested changes
Nov 29, 2023
| verbose=1, | ||
| learning_rate=1e-3, | ||
| eps=1e-6, | ||
| optimizer_mode='Adam', |
There was a problem hiding this comment.
В дополнение у нас получается две логики - одна optimizer_mode='Adam' и другая optimizer_mode=PSO() .
Будто бы тут надо всё унифицировать.
| x = torch.linspace(0, 1, grid_res+1) | ||
| t = torch.linspace(0, t_end, grid_res+1) | ||
|
|
||
| grid = grid_format_prepare([x,t], mode=mode).float() |
There was a problem hiding this comment.
Для кастомного лосса приходится доставать mode, видимо и вот эту функцию, которая должна быть скрыта для пользователя.
Кажется надо подумать над тем, как совместить новую абстракцию оптимизатора, со старым оптимизатором+mode.
* interface for data is refactored
|
We found out that the interface has a lot of thechnical debts and should be refactored, PR moved to #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.PSO optimizer is realized for all modes.
2. Small refactoring for Solver class. (futher changes are required)
3. PSO example and tutorial are added.
4. Update all doc strings in google style.