PSO+interface refactoring. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* interface for data is refactored
* PSO optimizer bug fix, example and tutorial.
* TT+ZO * callbacks --------- Co-authored-by: aminevdam <aminew.dam@yandex.ru>
SuperSashka
requested changes
Jan 31, 2024
tedeous/callbacks/cache.py
Outdated
| Union[None, dict, torch.Tensor]: best model with optimizator state. | ||
| """ | ||
|
|
||
| files = glob.glob(CacheUtils().cache_dir + '\*.tar') |
There was a problem hiding this comment.
Здесь пусть берётся из CacheUtils().cache_dir, но в классе Cache при инициализации есть параметр cache_dir. Сейчас нельзя прокинуть кастомный путь сюда. Хочу в этом же PR реализовать, чтобы кэш записывался в %TMPDIR%\tedeous_cache .
Подумайте, плез, как это исправить.
Closed
SuperSashka
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
It seems that we have done a good work with more to be done in future. As for now, we are good to go to main.
Main features:
-callbacks archtecture revamp - many user interface and backend changes for better understanding of the process
-yet more better than ever cache
-more optimizers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface refactoring + PSO optimization.