Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior Change: All comments before firstImport are treated as top-of-file #82

Merged
merged 13 commits into from
May 16, 2023
Merged

Behavior Change: All comments before firstImport are treated as top-of-file #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ee0bdd0
Preserve trailing comments on specifiers (they don't get automaticall…
fbartho May 12, 2023
1ab1031
Merge branch 'next' into fb/fix-lost-trailing-specifier-comments
fbartho May 14, 2023
e020081
Business logic change: All comments before firstImport are treated as…
fbartho May 14, 2023
1e2ff94
Neither inject-nor-delete blank-line following last top-of-file-comment
fbartho May 14, 2023
dbf31ee
Preserve trailing comments on specifiers (#80)
fbartho May 15, 2023
0bb7086
Preserve linebreaks in top of file comments
IanVS May 15, 2023
20a00f2
Add test with bad behavior when combining type and value
IanVS May 15, 2023
73eec7b
Handle type + value importing better
IanVS May 15, 2023
5d71054
Merge remote-tracking branch 'origin/next' into fb/protect-the-top-of…
IanVS May 15, 2023
bd07d70
Remove `.only` from tests
IanVS May 15, 2023
ddea041
Keep comments that end on line with import with owner
IanVS May 15, 2023
d9f69fb
Add a test case proving all blank-lines within specifier lists are co…
fbartho May 15, 2023
e9a9950
Slight reorganization around top-of-file comments (#84)
fbartho May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/ImportCommentsPreserved/__snapshots__/ppsi.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,22 @@ exports[`import-comments-document-top-all-are-untouched.ts - typescript-verify >
* This comment is before the first import, and so should never be moved.
* https://github.com/IanVS/prettier-plugin-sort-imports/issues/81
*/

// second comment
import type { A } from 'a'; // a
import { b } from 'b';
import type { A } from 'a';
import { a } from 'a';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/**
* @prettier
* This comment is before the first import, and so should never be moved.
* https://github.com/IanVS/prettier-plugin-sort-imports/issues/81
*/

// second comment

fbartho marked this conversation as resolved.
Show resolved Hide resolved
import { a, type A } from "a";
// a
import { b } from "b";

`;
Expand Down
4 changes: 3 additions & 1 deletion tests/ImportCommentsPreserved/import-comments-document-top-all-are-untouched.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* This comment is before the first import, and so should never be moved.
* https://github.com/IanVS/prettier-plugin-sort-imports/issues/81
*/

// second comment
import type { A } from 'a'; // a
import { b } from 'b';
import type { A } from 'a';
import { a } from 'a';