Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce object identifier attr #9524

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Introduce object identifier attr #9524

merged 2 commits into from
Oct 7, 2022

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Sep 9, 2022

fixes #9507

@yhabteab yhabteab added the area/icingadb New backend label Sep 9, 2022
@cla-bot cla-bot bot added the cla/signed label Sep 9, 2022
@icinga-probot icinga-probot bot added the needs feedback We'll only proceed once we hear from you again label Sep 9, 2022
@yhabteab yhabteab removed the needs feedback We'll only proceed once we hear from you again label Sep 9, 2022
@yhabteab yhabteab marked this pull request as ready for review September 9, 2022 14:29
Al2Klimov
Al2Klimov reviewed Sep 9, 2022
View reviewed changes
lib/base/configobject.ti Outdated Show resolved Hide resolved
lib/icingadb/icingadb-utility.cpp Outdated Show resolved Hide resolved
lib/icingadb/icingadb-utility.cpp Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the introduce-object-idx branch from 3e2511f to 4413fbd Compare September 9, 2022 16:31
@yhabteab yhabteab requested a review from Al2Klimov September 9, 2022 16:32
julianbrost
julianbrost reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine, the commit message still states the outdated attribute name though.

@yhabteab yhabteab force-pushed the introduce-object-idx branch from 4413fbd to 85c77bd Compare September 12, 2022 15:23
@julianbrost julianbrost self-requested a review October 6, 2022 13:35
@julianbrost julianbrost added the consider backporting Should be considered for inclusion in a bugfix release label Oct 7, 2022
@julianbrost julianbrost merged commit 2a4dc08 into master Oct 7, 2022
@icinga-probot icinga-probot bot deleted the introduce-object-idx branch October 7, 2022 08:20
@julianbrost julianbrost added this to the 2.14.0 milestone Oct 7, 2022
@julianbrost julianbrost mentioned this pull request Jul 4, 2023
Merged
3 tasks
Al2Klimov added a commit that referenced this pull request Jul 4, 2023
@Al2Klimov
Speed up Icinga DB config dump. #9524
427e170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

@Al2Klimov Al2Klimov Awaiting requested review from Al2Klimov

Assignees

@yhabteab yhabteab

Labels
area/icingadb New backend cla/signed consider backporting Should be considered for inclusion in a bugfix release
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

Avoid redundant GetObjectIdentifier() calls
3 participants
@yhabteab @julianbrost @Al2Klimov