Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icinga 2.14 #9760

Merged
merged 62 commits into from
Jul 12, 2023
Merged

Icinga 2.14 #9760

merged 62 commits into from
Jul 12, 2023

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented May 10, 2023

  • version
  • changelog
  • upgrading

@Al2Klimov Al2Klimov self-assigned this May 10, 2023
@cla-bot cla-bot bot added the cla/signed label May 10, 2023
@Al2Klimov Al2Klimov marked this pull request as ready for review May 15, 2023 10:32
@Al2Klimov Al2Klimov removed their assignment May 15, 2023
@Al2Klimov Al2Klimov added this to the 2.14.0 milestone May 15, 2023
@Al2Klimov Al2Klimov removed their assignment Jul 3, 2023
@Al2Klimov Al2Klimov requested a review from julianbrost July 3, 2023 14:53
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@julianbrost
Copy link
Contributor

Should be fine now, just misses release date, removing the commit disabling GitHub Actions and general cleanup of the commit history.

@Al2Klimov Al2Klimov self-assigned this Jul 5, 2023
@Al2Klimov Al2Klimov requested a review from julianbrost July 6, 2023 12:42
CHANGELOG.md Outdated
Comment on lines 136 to 183
### ITL

Add linux\_netdev check command. #9045

#### Command Argument Changes

* disk: don't pass -m (disk\_megabytes) by default. #9642
* disk: pass -X fuse.portal (disk\_exclude\_type) by default. #9459
* http: support multiple -k (http\_header) as array. #8574
* icmp: double defaults for -w (icmp\_wpl) and -c (icmp\_cpl). #9041
* logfiles: pass --winwarncrit (logfiles\_winwarncrit) without argument. #9056
* nwc\_health: pass SNMPv3-only args only when using SNMPv3. #9095
* vmware-esx-dc-runtime-tools and vmware-esx-soap-vm-runtime-tools:
rename --open-vm-tools to --open\_vm\_tools\_ok (vmware\_openvmtools). #9611

#### New Command Arguments

| Command | Argument | Custom Variable | PR |
|----------------------------------|----------------------------|------------------------------------------|-------|
| disk | -P | disk\_inode\_perfdata | #9494 |
| esxi\_hardware | --format | esxi\_hardware\_format | #9435 |
| esxi\_hardware | --pretty | esxi\_hardware\_pretty | #9435 |
| http | --verify-host | http\_verify\_host | #8005 |
| icingacli-businessprocess | --ack-is-ok | icingacli\_businessprocess\_ackisok | #9103 |
| icingacli-businessprocess | --blame | icingacli\_businessprocess\_blame | #9103 |
| icingacli-businessprocess | --colors | icingacli\_businessprocess\_colors | #9103 |
| icingacli-businessprocess | --downtime-is-ok | icingacli\_businessprocess\_downtimeisok | #9103 |
| icingacli-businessprocess | --root-cause | icingacli\_businessprocess\_rootcause | #9103 |
| mem | -a | mem\_available | #9385 |
| mongodb | --disable\_retry\_writes | mongodb\_disableretrywrites | #9539 |
| mongodb | --ssl-ca-cert-file | mongodb\_ssl\_ca\_cert\_file | #9610 |
| mysql | --extra-opts | mysql\_extra\_opts | #9197 |
| nrpe | -3 | nrpe\_version\_3 | #9296 |
| nrpe | -D | nrpe\_no\_logging | #9016 |
| nrpe | -P | nrpe\_payload\_size | #9032 |
| pgsql | --extra-opts | pgsql\_extra\_opts | #9197 |
| postgres | $PGCONTROLDATA (env. var.) | postgres\_pgcontroldata | #8929 |
| postgres | --datadir | postgres\_datadir | #8924 |
| postgres | --language | postgres\_language | #8924 |
| postgres | --perflimit | postgres\_perflimit | #8924 |
| ssl\_cert | --ignore-host-cn | ssl\_cert\_ignore\_host\_cn | #9512 |
| ssl\_cert | --ignore-ocsp-errors | ssl\_cert\_ignore\_ocsp\_errors | #9512 |
| ssl\_cert | --ignore-ocsp-timeout | ssl\_cert\_ignore\_ocsp\_timeout | #9512 |
| ssl\_cert | --ignore-tls-renegotiation | ssl\_cert\_ignore\_tls\_renegotiation | #9042 |
| ssl\_cert | --proxy | ssl\_cert\_proxy | #8927 |
| tcp | --sni | tcp\_sni | #9347 |
| vmware-esx-dc-runtime-tools | --no\_vm\_tools\_ok | vmware\_novmtools | #9611 |
| vmware-esx-soap-vm-runtime-tools | --no\_vm\_tools\_ok | vmware\_novmtools | #9611 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use `foo_bar` instead of foo\_bar instead? IMHO this would make it more pleasant to read in the plain text form and also is more grep-friendly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do this, but this would enlarge the table further. see also doc/ITL/disk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also doc/ITL/disk

Either I don't understand what you're referring to or what I should see there.

CHANGELOG.md Outdated
#### API

* Disallow breaking inter-object relationships by changing
relationship attributes at runtime, e.g. Service#host_name. #9407
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is a single unescaped _ here.

@Al2Klimov Al2Klimov removed their assignment Jul 7, 2023
@Al2Klimov Al2Klimov requested a review from julianbrost July 7, 2023 15:13
julianbrost
julianbrost previously approved these changes Jul 10, 2023
@Al2Klimov Al2Klimov merged commit cc104f8 into master Jul 12, 2023
@icinga-probot icinga-probot bot deleted the 214 branch July 12, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants