Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icinga 2.14 #9760
Icinga 2.14 #9760
Changes from 58 commits
560918d
976e6fe
d62bf9f
58671ed
2f52659
f31b6ae
3bbf7ef
9075645
4a3b4ee
533c826
1087f90
764acd5
bf1c3bc
cc7953e
ab5b08a
13cec68
1dcaec8
d150868
b73c7f6
b7303e5
ba1d31a
1c3bb7f
15f9287
bb0b0a9
72248e7
d18e9de
69f931b
659a008
57304a4
69033f2
9f98051
6393899
8c4751f
da390e1
33df7ae
7cbc321
3129f67
42f4228
28f2360
cf3c724
91f9fdd
ac0bacf
eb99df3
d001020
50a26cc
08e829a
4982bd9
2fc6935
c7aa859
84e165b
5ac8ff6
0215a02
e60908e
587697f
7f55b3d
427e170
68d97a4
1a93749
16b84b3
66b69d2
28665c5
deb997b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there is a single unescaped
_
here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
`foo_bar`
instead offoo\_bar
instead? IMHO this would make it more pleasant to read in the plain text form and also is more grep-friendly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could do this, but this would enlarge the table further. see also doc/ITL/disk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either I don't understand what you're referring to or what I should see there.