retry.Retryable(): treat ENOENT (AF_UNIX) like ECONNREFUSED, i.e. also retry #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
approved these changes
May 24, 2023
There was a problem hiding this comment.
Works!
2023-05-24T17:10:33.241+0200 INFO icinga-notifications Connecting to database at '/run/postgresql'
2023-05-24T17:10:33.242+0200 WARN database Can't connect to database. Retrying {"error": "dial unix /run/postgresql/.s.PGSQL.5432: connect: no such file or directory"}
2023-05-24T17:15:33.242+0200 FATAL icinga-notifications cannot connect to database {"error": "can't connect to database: can't retry: dial unix /run/postgresql/.s.PGSQL.5432: connect: no such file or directory", "errorVerbose": "dial unix /run/postgresql/.s.PGSQL.5432: connect: no such file or directory\ncan't retry\ngit.luolix.top/icinga/icingadb/pkg/retry.WithBackoff\n\t/Users/yhabteab/Workspace/go/src/icingadb/pkg/retry/retry.go:78
...
lippserd
requested changes
Jun 5, 2023
pkg/retry/retry.go
Outdated
| @@ -114,7 +114,7 @@ func Retryable(err error) bool { | |||
| // which is not considered temporary or timed out by Go. | |||
| err = opError.Err | |||
| } | |||
| if errors.Is(err, syscall.ECONNREFUSED) { | |||
| if errors.Is(err, syscall.ECONNREFUSED) || errors.Is(err, syscall.ENOENT) { | |||
| // syscall errors provide Temporary() and Timeout(), | |||
| // which do not include ECONNREFUSED, so we check this ourselves. | |||
There was a problem hiding this comment.
Please adjust the comment here as well.
…o retry During connect(2) we may get ECONNREFUSED between server's bind(2) and listen(2), but the most downtime between boot and service start the socket won't exist, yet. I.e. ENOENT is the de facto ECONNREFUSED of *nix sockets.
Al2Klimov
force-pushed
the
inconsistent-retry-behavior-between-tcp-and-unix-sockets-543
branch
from
a73e398 to
a3c1007
Compare
lippserd
approved these changes
Jun 5, 2023
julianbrost
deleted the
inconsistent-retry-behavior-between-tcp-and-unix-sockets-543
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During connect(2) we may get ECONNREFUSED between server's bind(2) and listen(2), but the most downtime between boot and service start the socket won't exist, yet. I.e. ENOENT is the de facto ECONNREFUSED of *nix sockets.
Tested this new commit vs. its parent commit. Test case - see:
fixes #543