Merge pull request rapidpro#461 from nyaruka/log_err_mark_fails

Log error if marking event fire as fired fails
Ilhasoft · Jul 19, 2021 · 013438c · 013438c
2 parents 91fd406 + 1113a33
commit 013438c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/core/tasks/campaigns/fire_campaign_event.go b/core/tasks/campaigns/fire_campaign_event.go
@@ -93,7 +93,10 @@ func (t *FireCampaignEventTask) Perform(ctx context.Context, rt *runtime.Runtime
 	if len(contactMap) > 0 {
 		rc := rp.Get()
 		for _, failed := range contactMap {
-			marker.RemoveTask(rc, campaignsLock, fmt.Sprintf("%d", failed.FireID))
+			rerr := marker.RemoveTask(rc, campaignsLock, fmt.Sprintf("%d", failed.FireID))
+			if rerr != nil {
+				log.WithError(rerr).WithField("fire_id", failed.FireID).Error("error unmarking campaign fire")
+			}
 		}
 		rc.Close()
 	}