Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer app code cleanup and improvements #554

Closed
wants to merge 4 commits into from
Closed

Timer app code cleanup and improvements #554

wants to merge 4 commits into from

Conversation

Riksu9000
Copy link
Contributor

Reduced duplication.
Hide buttons instead of creating and deleting them.
Make the active area of buttons larger than what they look like. This makes the small buttons easier to press.
Fix alignment.
Small tweaks like minutes going up to 60 instead of 59.

@Riksu9000 Riksu9000 changed the title Timer code cleanup Timer app code cleanup Aug 4, 2021
@hubmartin
Copy link
Contributor

Good work. I didn't know you can extend "clickable" area around some object. Seems like perfect fit for watches. This should be used almost everywhere in InfiniTime UI.

d7c05f8#diff-81ce0b0481912540170470032e08a92cb2353cd2dbe0acfdf49c0c19ef5191c8R32

@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Aug 4, 2021

Good work. I didn't know you can extend "clickable" area around some object. Seems like perfect fit for watches. This should be used almost everywhere in InfiniTime UI.

d7c05f8#diff-81ce0b0481912540170470032e08a92cb2353cd2dbe0acfdf49c0c19ef5191c8R32

Usually the buttons should be made as big as possible. In this case it might look weird to have the buttons be larger than the time, so I just extended the click area instead. I think this UI could do with a redesign in the future.

@Riksu9000 Riksu9000 changed the title Timer app code cleanup Timer app code cleanup and improvements Aug 29, 2021
@Riksu9000
Copy link
Contributor Author

Added long press repeat. Since the button is above the number, it is hard to see, but I'd rather rework the UI separately.

VID_20210829_135003.mp4

@Riksu9000 Riksu9000 closed this Jan 21, 2022
@Riksu9000 Riksu9000 deleted the timer_cleanup branch July 28, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants