Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: build precomputed data screen in admin #1730

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

JulienMattiussi
Copy link
Collaborator

@JulienMattiussi JulienMattiussi commented Oct 13, 2023

image

image

image

@JulienMattiussi JulienMattiussi added 👷‍♂️ Work In Progress PR en cours de développement 👷‍♂️ Do Not Merge PR bloquée ne devant pas être intégrée labels Oct 13, 2023
@JulienMattiussi JulienMattiussi force-pushed the feat/precomputed-screen branch from 18227cc to 3f89e96 Compare October 13, 2023 14:43
@JulienMattiussi JulienMattiussi marked this pull request as draft October 13, 2023 14:51
@JulienMattiussi JulienMattiussi removed the 👷‍♂️ Do Not Merge PR bloquée ne devant pas être intégrée label Oct 13, 2023
@JulienMattiussi JulienMattiussi force-pushed the feat/precomputed-screen branch from 09f153b to 76b32a3 Compare October 18, 2023 14:08
@JulienMattiussi JulienMattiussi marked this pull request as ready for review October 18, 2023 14:52
@JulienMattiussi JulienMattiussi force-pushed the feat/precomputed-screen branch from 041080c to b7a7c38 Compare October 18, 2023 15:11
@JulienMattiussi JulienMattiussi added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed 👷‍♂️ Work In Progress PR en cours de développement labels Oct 18, 2023
};

export const putPrecomputed = async (ctx, id) => {
const newResource = ctx.request.body;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newPrecomputed

// Delete existing data from dataset
// If we change the name or the rule, existing data is obsolete
const precomputed = await ctx.precomputed.findOneById(id);
await ctx.dataset.removeAttribute(precomputed.name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless for the precomputed

cancelJob(ctx, PRECOMPUTER);
}
await ctx.precomputed.delete(id);
await ctx.dataset.removeAttribute(precomputed.name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless for the precomputed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

@JulienMattiussi JulienMattiussi force-pushed the feat/precomputed-screen branch from b7a7c38 to b1fbe1e Compare October 19, 2023 09:19
@JulienMattiussi JulienMattiussi force-pushed the feat/precomputed-screen branch from 511d3c4 to 353c25a Compare October 19, 2023 09:57
@JulienMattiussi JulienMattiussi merged commit d7ffeb8 into master Oct 19, 2023
@parmentf parmentf deleted the feat/precomputed-screen branch November 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants