Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add .zenodo.json for author association #1597

Merged
merged 5 commits into from
Feb 18, 2020

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Feb 7, 2020

Based on https://github.com/nipy/nipype/blob/8fe05afcd7c716b52044837c96749ef420154fbb/.zenodo.json

This mechanism explicitly associates authors with their
ORCID.

This commit seeds the configuration. Additional authors should
self-identify by adding their ORCID to this file.

h/t @satra

We may want to add a note to CONTRIBUTING.md after merged.

@thewtex
Copy link
Member Author

thewtex commented Feb 7, 2020

After initialization, I will post to Discourse requesting contributors add their ORCID.

@satra
Copy link

satra commented Feb 7, 2020

@thewtex - in nipype we have some custom auto inclusion based on commits + management.

https://github.com/nipy/nipype/blob/master/tools/update_zenodo.py

just a note that no system of contributors for a large system is good enough for everyone !

@thewtex
Copy link
Member Author

thewtex commented Feb 7, 2020

@satra awesome! I'll try the script...

@thewtex thewtex requested a review from phcerdan February 7, 2020 19:42
@phcerdan
Copy link
Contributor

phcerdan commented Feb 7, 2020

This is gold, thanks @thewtex.

A related question, does somebody know what is the criteria of Google Scholar to parse Zenodo? It seems that some DOI's are integrated, but not all of them.

@jhlegarreta
Copy link
Member

Awesome @thewtex !

Adding a note to CONTRIBUTING.md looks fair. I think Nibabel has already some comment about it in their developper's guide, but the website seems to be down now.

To complete what @satra has said, a few related thoughts in an earlier issue:
#456 (comment)

If the script to parse authors based on the commits+management is finally found to fit our needs, we may want to add it to the Utilities/Maintenance folder, and add a section or note to the Release.md document.

A related question, does somebody know what is the criteria of Google Scholar to parse Zenodo? It seems that some DOI's are integrated, but not all of them.

No idea @phcerdan. Sorry.

@jhlegarreta
Copy link
Member

Adding a note to CONTRIBUTING.md looks fair. I think Nibabel has already some comment about it in their developper's guide, but the website seems to be down now.

Ah, sorry, it was Nypipe that had a complete web page and details about how to cite the toolkit and inviting developers to open a PR to modify the .zenodo.json file with their data when contributing for the first time:
https://nipype.readthedocs.io/en/latest/about.html

They also cross-reference the GitHub contributors section.

At the end of the page, they also have a section dedicated to acknowledging funding parties: might be an inspiration for #454.

@hjmjohnson
Copy link
Member

@thewtex FYI: These errors are similar to the ones I was encountering on a previous version of the #1471 branch yesterday.

@thewtex
Copy link
Member Author

thewtex commented Feb 14, 2020

https://github.com/nipy/nipype/blob/master/tools/update_zenodo.py

I added a script based on this and a version in nibabel @jhlegarreta referenced. Running this script is documented in the release process notes so .zenodo.json is automatically updated.

Adding a note to CONTRIBUTING.md looks fair.

Done.

we may want to add it to the Utilities/Maintenance folder, and add a section or note to the Release.md document.

Done.

These errors are similar to the ones I was encountering on a previous version of the #1471 branch yesterday.

The source of this is not clear or consistent -- I will exclude them from the CI to avoid false positives.

Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python failures are unrelated.

.zenodo.json Outdated Show resolved Hide resolved
@hjmjohnson
Copy link
Member

hjmjohnson commented Feb 14, 2020

FYI: https://orcid.org/orcid-search/quick-search/?searchQuery=Luis%20Ibanez

ORCID First Last _ Affiliations
https://orcid.org/0000-0003-2712-8584 Luis Ibanez   Google Inc, Kitware Inc, University of North Carolina at Chapel Hill, Université de Rennes 1, Universidad Industrial de Santander
https://orcid.org/0000-0002-9546-9703 Dženan Zukić   Kitware Inc, University of Siegen
https://orcid.org/0000-0002-6498-6273 Daniel Blezek   Mayo Clinic, Mayo Clinic Graduate School for Biomedical Sciences
https://orcid.org/0000-0002-9020-3770 Julien Jomier   Kitware SAS, Kitware Inc
No ORCID RIP Good Friend Bill Lorensen GE Research
https://orcid.org/0000-0002-7499-3514 Lydia Ng   Allen Institute for Brain Science
https://orcid.org/0000-0002-7862-8856 Stephen Aylward
https://orcid.org/0000-0002-4212-3362 Brian Avants
https://orcid.org/0000-0001-9418-5103 NICHOLAS TUSTISON   University of California Irvine, University of Virginia, Washington University in Saint Louis, Brigham Young University
https://orcid.org/0000-0002-9688-8950 Jean-Christophe Fillion-Robin   Kitware Inc, École Polytechnique Fédérale de Lausanne, Ecole Supérieure Chimie Physique Electronique de Lyon
https://orcid.org/0000-0001-8639-5354 Vincent Magnotta University of Iowa
https://orcid.org/0000-0001-8543-4016 Paul Yushkevich   University of Pennsylvania
https://orcid.org/0000-0002-8858-1254 Ali Ghayoor University of Iowa

|

@hjmjohnson
Copy link
Member

Just an idea, but for credit in the zendo file, should we have a "long-tail truncation" where at least N (2, 3, 10, 50) commits are necessary in order to be listed? I'm always concerned that a long tail listing dilutes the benefits of being listed. My knee jerk reaction would be some number that includes approximately the top 50 developers. Just an idea.

@jhlegarreta
Copy link
Member

Just an idea, but for credit in the zendo file, should we have a "long-tail truncation" where at least N (2, 3, 10, 50) commits are necessary in order to be listed? I'm always concerned that a long tail listing dilutes the benefits of being listed. My knee jerk reaction would be some number that includes approximately the top 50 developers. Just an idea.

I am in two minds about this. I think giving credit to all contributors, regardless of the number of commits, makes the community a more welcoming place. GitHub lists all contributors. and the list can be ordered in different ways, always showing the top contributors by number of commits or additions/deletions. And there are other sites, if I am not mistaken, that list the top contributors according to different criteria.

Remote module developers would not be credited by the current script either. May be this is also controversial, since they would not actually appear as having made a commit to ITK itself. Not sure if when the remote makes into ITK proper, the remote's history also makes it into ITK. If not, I assume they would not get their information into zenodo.

Sorry Hans, more questions than answers.

@phcerdan
Copy link
Contributor

Just an idea, but for credit in the zendo file, should we have a "long-tail truncation" where at least N (2, 3, 10, 50) commits are necessary in order to be listed? I'm always concerned that a long tail listing dilutes the benefits of being listed. My knee jerk reaction would be some number that includes approximately the top 50 developers. Just an idea.

I agree with Hans, long-tails dilutes the benefits indeed, NCommits>70(?), or NModules >= 1?

thewtex and others added 2 commits February 17, 2020 21:52
Based on https://github.com/nipy/nipype/blob/8fe05afcd7c716b52044837c96749ef420154fbb/.zenodo.json

This mechanism explicitly associates authors with their
[ORCID](https://orcid.org/).

This commit seeds the configuration. Additional authors should
self-identify by adding their ORCID to this file.
```
 git shortlog -nse
```
thewtex added a commit to thewtex/ITK that referenced this pull request Feb 18, 2020
As discussed in
InsightSoftwareConsortium#1597,
require 10 or more commits for .zenodo.json addition. This truncated the
long tail, and simplifies the contribution process for new contributors
by avoid the need to add an ORCID iD and affiliation to .zenodo.json. An
"ITK Community Members" creator is added to the end of the .zenodo.json
list to acknowledge the contributors with < 10 commits.
@thewtex
Copy link
Member Author

thewtex commented Feb 18, 2020

Just an idea, but for credit in the zendo file, should we have a "long-tail truncation" where at least N (2, 3, 10, 50) commits are necessary in order to be listed?

In d9a3ede a requirement for 10 commits is added. I think 50 is too high -- at 10, a contributor is often also contributing code reviews. This may also be helpful in reducing the burden for new contributors by not need to worry about adding an affiliation and an ORCID iD to .zenodo.json.

Remote module developers would not be credited by the current script either.

This is ok -- remote modules have their own repository, which can have a Zenodo record.

.zenodo.json Outdated Show resolved Hide resolved
As discussed in
InsightSoftwareConsortium#1597,
require 10 or more commits for .zenodo.json addition. This truncated the
long tail, and simplifies the contribution process for new contributors
by avoid the need to add an ORCID iD and affiliation to .zenodo.json. An
"ITK Community Members" creator is added to the end of the .zenodo.json
list to acknowledge the contributors with < 10 commits.
@thewtex
Copy link
Member Author

thewtex commented Feb 18, 2020

Merging -- @hjmjohnson if you create a separate PR for the ORCID's found, the contributors can review them.

@thewtex thewtex merged commit f7163f2 into InsightSoftwareConsortium:master Feb 18, 2020
@thewtex thewtex deleted the zenodo-json branch February 18, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants