Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Updates to the README #453

Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jan 29, 2019

  • Focus branding on the the simpler and broader name "Insight Toolkit
    (ITK)". ITK is well known as "ITK". Its use and applications go beyond
    segmentation and registration on medical images. The NLM does not desire
    branding of ITK.
  • Add Python package installation instructions.

- Focus branding on the the simpler and broader name "Insight Toolkit
(ITK)". ITK is well known as "ITK". Its use and applications go beyond
segmentation and registration on medical images. The NLM does not desire
branding of ITK.
- Add Python package installation intstructions.
Copy link
Contributor

@bpaniagua bpaniagua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blowekamp
Copy link
Member

blowekamp commented Jan 29, 2019

OK...

  • Perhaps an acknowledgment of the Insight Software Consortium is in order?
  • There has been Many funding sources for ITK over the years, perhaps some acknowledgment of that is in order?
  • As a developer of SimpleITK, I also feel this may be steering a lot to native ITK Python. There are many elements in the ITK community, SimpleITK has tried to provide little additional to ITK beyond a simplified interface for many languages. Perhaps an additional plug is due too.

@thewtex
Copy link
Member Author

thewtex commented Jan 29, 2019

* Perhaps an acknowledgment of the Insight Software Consortium is in order?

There is an existing reference to the ISC in the README.

* There has been Many funding sources for ITK over the years, perhaps some acknowledgment of that is in order?

Yes, a separate Acknowledgements section of the README would be nice, but that is a separate topic. I created an issue here: #454

* As a developer of SimpleITK, I also feel this may be steering a lot to native ITK Python. There are many elements in the ITK community, SimpleITK has tries to provide little additional to ITK beyond a simplified interface for many languages. Perhaps an additional plug is due too.

I do not think SimpleITK or MITK or ITK-SNAP or 3D Slicer or SMILI or Elastix or ANTS or VV or Seg3D or MeVisLab or the Orfeo Toolbox or DREAM.3D or ProjectXYZ should be given a special plug here.

@blowekamp
Copy link
Member

I do not think SimpleITK or MITK or ITK-SNAP or 3D Slicer or SMILI or Elastix or ANTS or VV or Seg3D or MeVisLab or the Orfeo Toolbox or DREAM.3D or ProjectXYZ should be given a special plug here.

Yes, it is a complex issue. There are MANY was to use ITK. While popular today, we don't want to convey that ITK is just python. It is a much more diverse toolkit with layers of community and organizational support.

@bpaniagua
Copy link
Contributor

I do not think SimpleITK or MITK or ITK-SNAP or 3D Slicer or SMILI or Elastix or ANTS or VV or Seg3D or MeVisLab or the Orfeo Toolbox or DREAM.3D or ProjectXYZ should be given a special plug here.

👍

@thewtex
Copy link
Member Author

thewtex commented Jan 29, 2019

Circle CI build warnings are unrelated.

@thewtex thewtex merged commit 54351d4 into InsightSoftwareConsortium:master Jan 29, 2019
@thewtex thewtex deleted the readme-improvements branch January 29, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants