BUG: Use unique filenames for Nifti tests #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Bug
|
@cookpa please take a look |
This was referenced May 13, 2024
thewtex
force-pushed
the
nifti-unique-filenames
branch
from
a7ebb9a
to
7ba89f7
Compare
jhlegarreta
approved these changes
May 13, 2024
|
Thanks for tracking this down @thewtex . The fixes look good to me. |
Yes, this works locally -- updating. |
When the tests are run in parallel they can try to write to or remove the same file from different processes, causing intermittent failures. Also add `const` where it is missing. Also use full paths as tests inputs, instead of changing directories, which is more explicit.
thewtex
force-pushed
the
nifti-unique-filenames
branch
from
7ba89f7
to
396d62f
Compare
N-Dekker
reviewed
May 13, 2024
hjmjohnson
approved these changes
May 13, 2024
N-Dekker
approved these changes
May 13, 2024
|
@thewtex THANK YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tests are run in parallel they can try to write to or remove
the same file from different processes, causing intermittent failures.
Also add
constwhere it is missing.Also use full paths as tests inputs, instead of changing directories,
which is more explicit.