Add ITK_DEFAULT_COPY_AND_MOVE and replace "manually" defaulted copy and move member function declarations
#4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
N-Dekker
force-pushed
the
ITK_DEFAULT_COPY_AND_MOVE
branch
from
2558ea1
to
0705afe
Compare
github-actions
bot
added
the
type:Infrastructure
jhlegarreta
approved these changes
May 8, 2024
N-Dekker
commented
May 9, 2024
|
Let's rebase after #4659 to get green CI. |
Explicitly "defaults" the copy constructor, copy assignment operator, move constructor, and move assignment operator of the specified class. Addresses issue InsightSoftwareConsortium#4645 "Defaulting copy constructor, copy assignment, move constructor, and move assignment functions", reported by Jon Haitz Legarreta Gorroño.
Instead of "manually" defaulting their copy and move member functions. Follow-up to pull request InsightSoftwareConsortium#4639 commit d1ebdfa "COMP: Fix implicit copy constructor definition deprecation warnings" by Jon Haitz Legarreta Gorroño
Instead of "manually" defaulting their copy and move member functions. Follow-up to two commits by Jon Haitz Legarreta Gorroño: pull request InsightSoftwareConsortium#4626 commit 9aff210 "COMP: Use default copy, move for construc, assign `RealTimeStamp`" pull request InsightSoftwareConsortium#4627 commit ec2677f "COMP: Use `default` copy and move construct and assign in `itk::Region`"
N-Dekker
force-pushed
the
ITK_DEFAULT_COPY_AND_MOVE
branch
from
0705afe
to
ab92350
Compare
hjmjohnson
merged commit 4f42280
into
InsightSoftwareConsortium:master
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address issue #4645 "Defaulting copy constructor, copy assignment, move constructor, and move
assignment functions", reported by Jon Haitz Legarreta Gorroño (@jhlegarreta).