Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default copy and move of iterators, using ITK_DEFAULT_COPY_AND_MOVE #4725

Conversation

N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Jun 14, 2024

Replaced hand-written copy-constructors and assignment operators of four iterators with the equivalent ITK_DEFAULT_COPY_AND_MOVE macro calls.


@github-actions github-actions bot added the area:Core Issues affecting the Core module label Jun 14, 2024
@N-Dekker N-Dekker marked this pull request as ready for review June 14, 2024 14:23
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on a glance!

@N-Dekker
Copy link
Contributor Author

I did look carefully at those hand-written copy-constructors and assignment operators to check that they really just do "the default thing". But honestly an extra glance wouldn't harm 😃

Note that some copy functions of other iterators seem to do non-default things, for example:

I did not include those seemingly non-default-behaving copy-functions with this pull request.

@hjmjohnson hjmjohnson merged commit f7f9bd6 into InsightSoftwareConsortium:master Jun 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants