-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: Replace Fill(0)
on local variables with {}
initialization
#4897
Merged
thewtex
merged 1 commit into
InsightSoftwareConsortium:master
from
N-Dekker:Replace-Fill-0-with-initialization
Oct 24, 2024
Merged
STYLE: Replace Fill(0)
on local variables with {}
initialization
#4897
thewtex
merged 1 commit into
InsightSoftwareConsortium:master
from
N-Dekker:Replace-Fill-0-with-initialization
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Notepad++, Replace in Files, doing: Find what: ^( [ ]+[^ ].* )(\w+);[\r\n]+ [ ]+\2\.Fill\(0\.?0?\); Replace with: $1$2{}; Filters: itk*.cxx;itk*.hxx;itk*.h Directory: D:\Src\ITK\Modules [v] Match case (*) Regular expression Follow-up to pull request InsightSoftwareConsortium#4881 commit 569a8b6 "STYLE: Replace Fill(0) with {} initializer for local variables in tests"
github-actions
bot
added
type:Testing
Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
area:Core
Issues affecting the Core module
area:Filtering
Issues affecting the Filtering module
area:IO
Issues affecting the IO module
area:Registration
Issues affecting the Registration module
area:Segmentation
Issues affecting the Segmentation module
type:Style
Style changes: no logic impact (indentation, comments, naming)
area:Numerics
Issues affecting the Numerics module
labels
Oct 24, 2024
dzenanz
approved these changes
Oct 24, 2024
hjmjohnson
approved these changes
Oct 24, 2024
thewtex
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Oct 25, 2024
Using Notepad++, Replace in Files, doing: Find what: ^( [ ]+[^ ].* )(\w+);[\r\n]+ [ ]+\2\.Fill\(.*{}\); Replace with: $1$2{}; Directory: D:\Src\ITK\Modules - Follow-up to pull request InsightSoftwareConsortium#4897 commit 4733550 "STYLE: Replace `Fill(0)` on local variables with `{}` initialization"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Oct 25, 2024
Using Notepad++, Replace in Files, doing: Find what: ^( [ ]+[^ ].* )(\w+);[\r\n]+ [ ]+\2\.Fill\(.*{}\); Replace with: $1$2{}; Directory: D:\Src\ITK\Modules Manually removed the ValueType alias from `BarycentricCombination::Evaluate`, to avoid "unused type alias" warnings. - Follow-up to pull request InsightSoftwareConsortium#4897 commit 4733550 "STYLE: Replace `Fill(0)` on local variables with `{}` initialization"
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Oct 26, 2024
Replaced code of the form Type var; var.Fill(0); and Type var; var.Fill(ElementType{}); with `Type var{};` Using Notepad++, Replace in Files, doing: Find what: ^( [ ]+)([^ ].* )(\w+);[\r\n]+\1\3\.Fill\(0\.?0?\); Find what: ^( [ ]+)([^ ].* )(\w+);[\r\n]+\1\3\.Fill\(.*{}\); Replace with: $1$2$3{}; [v] Match case (*) Regular expression - Following ITK pull request InsightSoftwareConsortium/ITK#4897 commit InsightSoftwareConsortium/ITK@4733550
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
Oct 26, 2024
Replaced code of the form Type var; var.Fill(0); and Type var; var.Fill(ElementType{}); with `Type var{};` Using Notepad++, Replace in Files, doing: Find what: ^( [ ]+)([^ ].* )(\w+);[\r\n]+\1\3\.Fill\(0\.?0?\); Find what: ^( [ ]+)([^ ].* )(\w+);[\r\n]+\1\3\.Fill\(.*{}\); Replace with: $1$2$3{}; [v] Match case (*) Regular expression - Following ITK pull request InsightSoftwareConsortium/ITK#4897 commit InsightSoftwareConsortium/ITK@4733550
N-Dekker
added a commit
to N-Dekker/ITKSphinxExamples
that referenced
this pull request
Nov 4, 2024
- Follow-up to ITK pull request InsightSoftwareConsortium/ITK#4897 commit InsightSoftwareConsortium/ITK@4733550
N-Dekker
added a commit
to N-Dekker/ITKSphinxExamples
that referenced
this pull request
Nov 4, 2024
- Follow-up to ITK pull request InsightSoftwareConsortium/ITK#4897 commit InsightSoftwareConsortium/ITK@4733550
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:Core
Issues affecting the Core module
area:Filtering
Issues affecting the Filtering module
area:IO
Issues affecting the IO module
area:Numerics
Issues affecting the Numerics module
area:Registration
Issues affecting the Registration module
area:Segmentation
Issues affecting the Segmentation module
type:Style
Style changes: no logic impact (indentation, comments, naming)
type:Testing
Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Notepad++, Replace in Files, doing:
Fill(0)
with{}
initializer for local variables in tests #4881 commit 569a8b6