Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Replace Fill(T{}) on local variables with {} initialization #4904

Merged
merged 1 commit into from
Oct 27, 2024
Merged

STYLE: Replace Fill(T{}) on local variables with {} initialization #4904

merged 1 commit into from
Oct 27, 2024
+17 −35

Conversation

N-Dekker
Copy link
Contributor

Using Notepad++, Replace in Files, doing:

Find what: ^( [ ]+[^ ].* )(\w+);[\r\n]+ [ ]+\2\.Fill\(.*{}\);
Replace with: $1$2{};
Directory: D:\Src\ITK\Modules

@github-actions github-actions bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming) area:Numerics Issues affecting the Numerics module labels Oct 25, 2024
@N-Dekker
STYLE: Replace Fill(T{}) on local variables with {} initialization
d905400 
Using Notepad++, Replace in Files, doing:

    Find what: ^( [ ]+[^ ].* )(\w+);[\r\n]+ [ ]+\2\.Fill\(.*{}\);
    Replace with: $1$2{};
    Directory: D:\Src\ITK\Modules

Manually removed the ValueType alias from `BarycentricCombination::Evaluate`, to
avoid "unused type alias" warnings.

- Follow-up to pull request InsightSoftwareConsortium#4897
commit 4733550
"STYLE: Replace `Fill(0)` on local variables with `{}` initialization"
@N-Dekker N-Dekker force-pushed the Replace-Fill-empty-init-list-with-initialization branch from 96654b7 to d905400 Compare October 25, 2024 20:35
@N-Dekker
Copy link
Contributor Author

/azp run ITK.macOS

@N-Dekker N-Dekker marked this pull request as ready for review October 26, 2024 08:31
@jhlegarreta jhlegarreta merged commit 7fdb792 into InsightSoftwareConsortium:master Oct 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Segmentation Issues affecting the Segmentation module type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N-Dekker @dzenanz @jhlegarreta