Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix Node.js warnings linked to GitHub actions #164

Conversation

jhlegarreta
Copy link
Member

Fix Node.js warnings linked to GitHub actions: bump actions/checkout@v4.

Take advantage of the commit to bump upload-artifact@v4 and actions/setup-python@v5.

Fixes:

Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3.
For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

raised for example in:
https://github.com/InsightSoftwareConsortium/ITKTrimmedPointSetRegistration/actions/runs/9753007352

@jhlegarreta jhlegarreta force-pushed the FixGitHubActionsNodejsWarning branch from d044cd1 to 7da91ca Compare July 2, 2024 22:09
@dzenanz
Copy link
Member

dzenanz commented Jul 3, 2024

MacOS one builds multiple wheels. MacOSWheels.zip artifact has the following content:
Screenshot 2024-07-03 12 22 12

@jhlegarreta
Copy link
Member Author

Thanks for the investigation @dzenanz.

The issue comes from

It is the outer GHA workflow that is creating multiple artifact (one for each Python version) with the same name. It does not happen for Linux and Windows because:

name: WindowWheel3.${{ matrix.python-version-minor }}

name: LinuxWheel${{ matrix.python-version }}

PR #165.

Fix `Node.js` warnings linked to GitHub actions: bump
`actions/checkout@v4`.

Take advantage of the commit to bump `upload-artifact@v4` and
`actions/setup-python@v5`.

Fixes:
```
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3.
For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

raised for example in:
https://github.com/InsightSoftwareConsortium/ITKTrimmedPointSetRegistration/actions/runs/9753007352
@jhlegarreta jhlegarreta force-pushed the FixGitHubActionsNodejsWarning branch from 7da91ca to 9d8e786 Compare July 6, 2024 15:51
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta thanks!

@thewtex thewtex merged commit b10b18c into InsightSoftwareConsortium:main Jul 8, 2024
17 checks passed
@jhlegarreta jhlegarreta deleted the FixGitHubActionsNodejsWarning branch July 8, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants