Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Use a different name for each macOS wheel name #165

Merged
merged 2 commits into from
Jul 5, 2024
Merged

BUG: Use a different name for each macOS wheel name #165

merged 2 commits into from
Jul 5, 2024

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Jul 3, 2024 •
edited
Loading

  • BUG: Use a different name for each macOS wheel name
  • STYLE: Make the wheel names consistent

@jhlegarreta
BUG: Use a different name for each macOS wheel name
e409273 
Use a different name for each macOS wheel name: append the Python minor
version to the name.

Fixes:
```
Error: Failed to CreateArtifact: Received non-retryable error:
Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```

raised for example in:
https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/9768626552/job/26966536773?pr=164#step:9:21
@jhlegarreta jhlegarreta mentioned this pull request Jul 3, 2024
Merged
@jhlegarreta
STYLE: Make the wheel names consistent
eec729b 
Make the wheel names consistent:
- Add the label `3` (for Python 3.x) before the minor version.
- Remove the plural `s` from the macOS wheel names.

Take advantage of the commit to rename the Windows wheel name root from
`Window` to `Windows` to honor the OS name.
dzenanz
dzenanz approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS wheels might now be duplicated, i.e. all of them having the same contents. Which got me thinking, do we even need wheels for this template project?

@jhlegarreta
Copy link
Member Author

MacOS wheels might now be duplicated, i.e. all of them having the same contents.

Not sure if I see this, unless you mean those of the template vs. the module.

Which got me thinking, do we even need wheels for this template project?

🤷 Maybe yes to generate a remote? Maybe @thewtex can tell us better.

@thewtex
Copy link
Member

thewtex commented Jul 5, 2024

The wheels can be helpful to validate the template. Even if they are not uploaded to PyPI, they are available for examination in the GitHub Web UI.

thewtex
thewtex approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta thanks!

@thewtex thewtex merged commit 4207037 into InsightSoftwareConsortium:main Jul 5, 2024
17 checks passed
@jhlegarreta jhlegarreta deleted the FixMacOSWheelNamingError branch July 5, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @thewtex @dzenanz