Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Remove ITKModuleTemplate remain files. #3

Merged
merged 1 commit into from
Mar 17, 2019
Merged

ENH: Remove ITKModuleTemplate remain files. #3

merged 1 commit into from
Mar 17, 2019

Conversation

jhlegarreta
Copy link
Member

Remove ITKModuleTemplate remain files.

@jhlegarreta
ENH: Remove ITKModuleTemplate remain files.
85c4e4c 
Remove `ITKModuleTemplate` remain files.
@jhlegarreta
Copy link
Member Author

I'll submit a skeleton for the test files and wrapping files in two subsequent PRs.

@vikramc1 Completing them to bring the module reproducible and usable in Python would be nice.

@jhlegarreta
Copy link
Member Author

Python wrapping files are not present in this PR so I'd dare to say that the Python packaging failing and CMake warnings make sense:

CMake Warning:
  Manually-specified variables were not used by the project:

    ITK_USE_SYSTEM_SWIG
    PYTHON_INCLUDE_DIR
    PYTHON_LIBRARY
    SWIG_EXECUTABLE
    WRAP_ITK_INSTALL_COMPONENT_IDENTIFIER

This was referenced Mar 17, 2019
Merged
Merged
thewtex
thewtex approved these changes Mar 17, 2019
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhlegarreta !

@thewtex thewtex merged commit c282b21 into InsightSoftwareConsortium:master Mar 17, 2019
@jhlegarreta jhlegarreta deleted the RemoveITKModuleTemplateRemainFiles branch March 17, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewtex thewtex thewtex approved these changes

@vikramc1 vikramc1 Awaiting requested review from vikramc1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhlegarreta @thewtex