ENH: Add tests to the module. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Awesome @jhlegarreta ! Could this please be rebased on Even without full coverage, we can create an issue to improve the tests, and merge this to get the builds going again. |
|
359e693 rebased on master. |
jhlegarreta
changed the title
Add tests to the module.
…mage
To address:
In file included from /home/matt/src/ITKNDReg/test/itkWrapExtrapolateImageFunctionTest.cxx:19:
/home/matt/src/ITKNDReg/include/itkWrapExtrapolateImageFunction.h:112:8: warning: 'SetInputImage' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetInputImage(const InputImageType*ptr)
^
/home/matt/src/ITKNDReg/test/itkWrapExtrapolateImageFunctionTest.cxx:41:3: note: in instantiation of template class 'itk::WrapExtrapolateImageFunction<itk::Image<float, 2>, float>' requested here
WrapExtrapolateImageFunctionType::Pointer wrapExtrapolateImageFunction =
^
/home/matt/src/ITK/Modules/Core/ImageFunction/include/itkImageFunction.h:111:16: note: overridden virtual function is here
virtual void SetInputImage(const InputImageType *ptr);
We do not create any libraries (there is no longer an "src" directory).
…ilterTest This has issues and does not appear to be exercised in the ndreg repository.
Detected by: include/itkMetamorphosisImageRegistrationMethodv4.h:74:8: warning: 'ThreadedGenerateData' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] ThreadedGenerateData has been replace by DynamicThreadedGenerateData in ITK 5: https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/ITK5MigrationGuide.md
To address: include/itkMetamorphosisImageRegistrationMethodv4.h:228:8: warning: 'StartOptimization' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
To address: include/itkMetamorphosisImageRegistrationMethodv4.hxx:59:90: warning: instantiation of variable 'itk::NumericTraits<itk::CovariantVector<double, 2> >::One' required here, but no definition is available [-Wundefined-var-template]
To address: d:\a\1\s\include\itkMetamorphosisImageRegistrationMethodv4.hxx(144): warning C4101: 'B': unreferenced local variable
|
I really did not take the time to looks at the issues of this PR, but now that I look at them, probably the CI failures in the rest of the PRs are related to some of these commits, so thanks @thewtex . This is awesome 👍 |
|
The module builds fine now ✔️ , but Python packaging seems not to work properly: May be we are having issues with the pipeline configuration? |
|
Thanks @jhlegarreta -- even these minimal test caught a few bugs! @vikramc1 more testing would certainly be helpful ;-). @jhlegarreta yes, can you please rebase the other branches? |
|
Sure I can. Thanks @thewtex . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to the module.