feat: support app flows APIs #1138

abdelhamid-f-nasser · 2024-02-19T10:48:39Z

Description of the change

Support thew App Flows feature and it's below APIs:
- APM.startFlow
- APM.endFlow
- APM.setTraceAttribute
Deprecate the following execution traces APIs in favor of the new app flow APIs:
- APM.startExecutionTrace
- Trace.end()
- Trace.setAttribute

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: APM-19535

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests

Code review

This pull request has a descriptive title and information useful to a reviewer
Issue from task tracker has a link to this pull request

mnoseir · 2024-02-19T10:59:54Z

	Warnings
⚠️	You have not included a CHANGELOG entry! You can find it at CHANGELOG.md.

Coverage Report

Label	Coverage	Status
JavaScript	96.2%	✅
Android	47.2%	✅
iOS	41.3%	✅

Generated by 🚫 dangerJS against 65fcb14

a7medev

Great job @abdelhamid-f-nasser 👏🏼 Please check the comments added. 🙏🏼

CHANGELOG.md

android/src/main/java/com/instabug/reactlibrary/RNInstabugAPMModule.java

examples/default/ios/InstabugTests/InstabugAPMTests.m

src/models/Trace.ts

abdelhamid-f-nasser · 2024-02-20T16:40:28Z

Great catch @a7medev 🎣 👍 , please recheck and let me know if you have any further suggestions.

Deprecate execution traces in favor of AppFlows APIs.

CHANGELOG.md

src/models/Trace.ts

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

ahmedAlaaInstabug

Good job

* feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * feat: add more crash scenarios to example app (#1131) * feat(example): add nested complex views (#1111) Jira ID: MOB-13737 * fix hybrid mode code push version init (#1108) * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * ci: migrate macos machines to m1 (#1114) * feat: support identify user by id (#1115) Jira ID: MOB-13746 * ci: replace d11 cluster url in UploadSourcemaps (#1122) * fix(android): resolve private views through UI manager directly (#1121) * feat: support switching to native network interception (#1120) * feat(example): Add more sdk crashes buttons * chore(android): ignore jetbrains ide run configurations (#1110) Jira ID: MOB-13736 * feat(example): Add more sdk crashes buttons * fix dev merge issue * feat_add_crash_buttons * feat_add_crash_buttons * feat_add_crash_buttons * fix: PlatformListTile typo name --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com> * feat_add_setNDKCrashesEnabled * fix android_testing issue * rename_test_cases * fix_pr_comments * feat/add-ndk-demo-crash-buttons * chore: add ChangeLog changes * Update CHANGELOG.md Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> * fix:lint issue * fix: CHANGELOG typo issue Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> --------- Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com> Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com> Co-authored-by: AbdElHamid Nasser <anasser@instabug.com>

* chore(android): bump sdk to v12.7.1 (#1134) * feat:add-upload-so-files-command * feat:add-upload-so-files-command * fix: add file path check * feat: add file validations * feat: add file validations * chore: format UploadSoFiles.ts * chore: add changes in changeLog --------- Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

* feat(example): add survey with token action * refactor: export onPress functions to methods

* feat(example): customize chat settings * feat(example): customize chat settings * fix: pr comments

CHANGELOG.md

src/modules/APM.ts

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

The base branch was changed.

# Conflicts: # android/native.gradle

InstabugCI · 2024-04-19T15:19:19Z

Coverage Report

Label	Coverage	Status
JavaScript	96.3%	✅
Android	48.3%	✅
iOS	42.3%	✅

Generated by 🚫 dangerJS against 6aa71cb

a7medev

LGTM 👌🏼

abdelhamid-f-nasser changed the title ~~chore(android): deprecate execution traces APIs~~ feat: support app flows APIs Feb 19, 2024

abdelhamid-f-nasser added pending-android Waiting for Android release pending-ios Waiting for iOS release labels Feb 19, 2024

abdelhamid-f-nasser marked this pull request as ready for review February 19, 2024 11:08

abdelhamid-f-nasser requested review from a7medev and ahmedAlaaInstabug February 19, 2024 11:08

abdelhamid-f-nasser self-assigned this Feb 20, 2024

a7medev requested changes Feb 20, 2024

View reviewed changes

abdelhamid-f-nasser requested a review from a7medev February 20, 2024 16:40

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch from 8c333f4 to 5c23828 Compare February 21, 2024 07:53

abdelhamid-f-nasser added 4 commits February 21, 2024 09:53

chore(android): deprecate execution traces APIs

616fa69

Deprecate execution traces in favor of AppFlows APIs.

chore: deprecate execution traces APIs

0104d26

Deprecate execution traces in favor of AppFlows APIs.

chore(ios): deprecate execution traces APIs

20de15d

Deprecate execution traces in favor of AppFlows APIs.

docs: update changelog.md

c2079ad

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch from 5c23828 to 44e597a Compare February 21, 2024 07:54

feat: support app flows

676e611

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch 2 times, most recently from 3a328b7 to 03d2baa Compare February 21, 2024 09:53

docs: update changelog.md

e061d55

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch from 03d2baa to e061d55 Compare February 21, 2024 09:54

a7medev requested changes Feb 21, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

src/models/Trace.ts Outdated Show resolved Hide resolved

abdelhamid-f-nasser and others added 2 commits February 21, 2024 13:00

chore: add eslint jsdoc plugin and update imports

c0e5085

docs: update changelog.md

3a1880b

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

abdelhamid-f-nasser requested a review from a7medev February 21, 2024 11:12

ahmedAlaaInstabug previously approved these changes Feb 28, 2024

View reviewed changes

ahmedAlaaInstabug and others added 3 commits February 28, 2024 19:48

ahmedAlaaInstabug and others added 4 commits February 28, 2024 19:49

feat(example): survey with token actions (#1157)

17da2fe

* feat(example): add survey with token action * refactor: export onPress functions to methods

feat(example): customize chat settings (#1156)

bc7d913

* feat(example): customize chat settings * feat(example): customize chat settings * fix: pr comments

Merge remote-tracking branch 'origin/dev' into dev

683747d

Merge branch 'dev' into feat/support-app-flows

66d1cb1

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch from 36e0945 to 66d1cb1 Compare February 28, 2024 17:59

abdelhamid-f-nasser added 5 commits February 28, 2024 21:35

chore(ios): add app flows snapshot

ae275b8

chore(android): add app flows snapshot

eab2af3

Merge remote-tracking branch 'origin/dev' into feat/support-app-flows

86f4ff0

docs(android): update setFlowAttribute param docs

a6d13d8

Merge remote-tracking branch 'origin/dev' into feat/support-app-flows

4f47756

abdelhamid-f-nasser added the READY FOR MERGE Reviewed and ready for merge (after release request) label Mar 6, 2024

abdelhamid-f-nasser requested a review from ahmedAlaaInstabug March 6, 2024 08:54

docs: update changelog.md

367054b

a7medev requested changes Mar 11, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

src/modules/APM.ts Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/dev' into feat/support-app-flows

eb676ab

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch from 64c3a29 to eb676ab Compare April 3, 2024 13:00

abdelhamid-f-nasser and others added 2 commits April 3, 2024 15:00

Update CHANGELOG.md

91fd7ef

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

Update src/modules/APM.ts

c004531

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

abdelhamid-f-nasser force-pushed the feat/support-app-flows branch from 250b0f9 to c004531 Compare April 14, 2024 12:57

Base automatically changed from dev to master April 14, 2024 19:42

mrashed98 added this to the 24Q1C2 milestone Apr 16, 2024

abdelhamid-f-nasser changed the base branch from master to dev April 16, 2024 13:16

ahmedAlaaInstabug added 2 commits April 19, 2024 16:48

Merge branch 'refs/heads/dev' into feat/support-app-flows

642aaaa

# Conflicts: # android/native.gradle

fix: podFile issue

6aa71cb

ahmedAlaaInstabug requested a review from a7medev April 19, 2024 15:10

a7medev approved these changes Apr 19, 2024

View reviewed changes

ahmedAlaaInstabug merged commit 567f9fc into dev Apr 19, 2024
10 of 13 checks passed

ahmedAlaaInstabug deleted the feat/support-app-flows branch April 19, 2024 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support app flows APIs #1138

feat: support app flows APIs #1138

abdelhamid-f-nasser commented Feb 19, 2024 •

edited

Loading

mnoseir commented Feb 19, 2024

a7medev left a comment

abdelhamid-f-nasser commented Feb 20, 2024

ahmedAlaaInstabug left a comment

InstabugCI commented Apr 19, 2024

a7medev left a comment

feat: support app flows APIs #1138

feat: support app flows APIs #1138

Conversation

abdelhamid-f-nasser commented Feb 19, 2024 • edited Loading

Description of the change

Type of change

Related issues

Checklists

Development

Code review

mnoseir commented Feb 19, 2024

Coverage Report

a7medev left a comment

Choose a reason for hiding this comment

abdelhamid-f-nasser commented Feb 20, 2024

ahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

InstabugCI commented Apr 19, 2024

Coverage Report

a7medev left a comment

Choose a reason for hiding this comment

abdelhamid-f-nasser commented Feb 19, 2024 •

edited

Loading