Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): change parameters used in inner class to final #1239

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix(android): change parameters used in inner class to final #1239

merged 3 commits into from
Jul 2, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Jun 24, 2024 •
edited
Loading

Description of the change

Mark the parameters used inside inner classes in the Android code as final to fix errors like the one below in Java 7 and earlier.

Error: local variable version is accessed from within inner class; needs to be declared final in RNInstabugReactnativeModule.java

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: INSD-11725

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Jun 24, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jun 24, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 99.2% ✅
Android 49.3% ✅
iOS 43.3% ✅

Generated by 🚫 dangerJS against 9daf9ce

@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/13.1.1-INSD-11725

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/13.1.1-INSD-11725

@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/13.1.1-INSD-11725

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/13.1.1-INSD-11725

@a7medev a7medev merged commit ed10523 into dev Jul 2, 2024
12 checks passed
@a7medev a7medev deleted the fix/android-final-parameters branch July 2, 2024 08:44
mzelzoghbi pushed a commit that referenced this pull request Jul 7, 2024
@a7medev @mzelzoghbi
fix(android): change parameters used in inner class to final (#1239)
c6138ea
ahmedAlaaInstabug pushed a commit that referenced this pull request Sep 19, 2024
@a7medev @ahmedAlaaInstabug
fix(android): change parameters used in inner class to final (#1239)
87da4e5
ahmedAlaaInstabug added a commit that referenced this pull request Sep 19, 2024
@ahmedAlaaInstabug
fix: Replace Thrown Errors with Logs
d6e9f14 
sss
chore(ios): bump sdk to v13.1.0 (#1227)

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

chore(android): bump sdk to v13.1.1 (#1228)

* chore(android): bump android sdk v13.1.1

feat: enhance non-fatals support  (#1194)

* add non fatal api
---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

fix:  read env variable in sourcemap (#1232)

* fix sourcemap issue

* fix sourcemap issue

* fix sourcemap issue

* Update typo in CHANGELOG.md

---------

Co-authored-by: Andrew Amin <160974398+AndrewAminInstabug@users.noreply.github.com>

Release:v13.1.1 (#1231)

* release/v13.1.1

* Update CHANGELOG.md

Update CHANGELOG.md

chore(deps): bump @babel/traverse in /examples/default

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.24.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump follow-redirects from 1.15.2 to 1.15.6

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: cont work after logging

fix(android): change parameters used in inner class to final (#1239)

chore(android): bump sdk to v13.2.0 (#1245)

* chore(android): bump sdk to v13.2.0

* chore: update changelog

chore(ios): bump sdk to v13.2.0 (#1246)

release: v13.2.0 (#1247)

chore: resolve issues in changelog (#1249)

feat(example): add apm screen (#1141)

fix(android): resolve an OOM in network logs (#1244)

fix(android): APM network logging(#1253)

* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module

feat: export upload utils (#1252)

chore(example): remove flipper (#1259)

fix(android): pass network start time in microseconds (#1260)

* fix: network timestamp in android side

* fix: PR comments

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: support feature flags with variants (#1230)

Jira ID: MOB-14684

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

chore(android): bump android sdk to v13.3.0 (#1261)

chore(ios): bump sdk to v13.3.0 (#1262)

release: v13.3.0 (#1263)

chore: remove duplicate app flows entries in changelog (#1264)

chore: remove duplicate execution traces deprecation in changelog (#1265)

feat: navigation tracking support with expo router (#1270)

* feat: add screen tracker on screen change listener and tests

* feat (example): add screen change listener

chore: enhance expo router tracking support (#1272)

ci: generalize enterprise releases (#1275)

ci: run tests before enterprise releases (#1271)

ci: publish snapshots to npm (#1274)

fix: PR comments

fix(ios): network log empty response body (#1273)

fix: drop non-error objects when reporting errors (#1279)

* Fix: omitted non-error objects when logging errors

* ci: publish snapshots to npm (#1274)

* Fix: omitted non-error objects when logging errors

* fix: use warn instead of logs

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* fix: merge issues

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: capture client error in the network interceptor (#1257)

* feat/support-capture-client-error-in-xhr-requests
---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>
Co-authored-by: kholood <keassa@instabug.com>

fix: APM test cases
a7medev pushed a commit that referenced this pull request Nov 6, 2024
@ahmedAlaaInstabug
fix: replace thrown errors with logs (#1220)
1dc56b5 
* fix: Replace Thrown Errors with Logs

sss
chore(ios): bump sdk to v13.1.0 (#1227)

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

chore(android): bump sdk to v13.1.1 (#1228)

* chore(android): bump android sdk v13.1.1

feat: enhance non-fatals support  (#1194)

* add non fatal api
---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

fix:  read env variable in sourcemap (#1232)

* fix sourcemap issue

* fix sourcemap issue

* fix sourcemap issue

* Update typo in CHANGELOG.md

---------

Co-authored-by: Andrew Amin <160974398+AndrewAminInstabug@users.noreply.github.com>

Release:v13.1.1 (#1231)

* release/v13.1.1

* Update CHANGELOG.md

Update CHANGELOG.md

chore(deps): bump @babel/traverse in /examples/default

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.24.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump follow-redirects from 1.15.2 to 1.15.6

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: cont work after logging

fix(android): change parameters used in inner class to final (#1239)

chore(android): bump sdk to v13.2.0 (#1245)

* chore(android): bump sdk to v13.2.0

* chore: update changelog

chore(ios): bump sdk to v13.2.0 (#1246)

release: v13.2.0 (#1247)

chore: resolve issues in changelog (#1249)

feat(example): add apm screen (#1141)

fix(android): resolve an OOM in network logs (#1244)

fix(android): APM network logging(#1253)

* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module

feat: export upload utils (#1252)

chore(example): remove flipper (#1259)

fix(android): pass network start time in microseconds (#1260)

* fix: network timestamp in android side

* fix: PR comments

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: support feature flags with variants (#1230)

Jira ID: MOB-14684

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

chore(android): bump android sdk to v13.3.0 (#1261)

chore(ios): bump sdk to v13.3.0 (#1262)

release: v13.3.0 (#1263)

chore: remove duplicate app flows entries in changelog (#1264)

chore: remove duplicate execution traces deprecation in changelog (#1265)

feat: navigation tracking support with expo router (#1270)

* feat: add screen tracker on screen change listener and tests

* feat (example): add screen change listener

chore: enhance expo router tracking support (#1272)

ci: generalize enterprise releases (#1275)

ci: run tests before enterprise releases (#1271)

ci: publish snapshots to npm (#1274)

fix: PR comments

fix(ios): network log empty response body (#1273)

fix: drop non-error objects when reporting errors (#1279)

* Fix: omitted non-error objects when logging errors

* ci: publish snapshots to npm (#1274)

* Fix: omitted non-error objects when logging errors

* fix: use warn instead of logs

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* fix: merge issues

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: capture client error in the network interceptor (#1257)

* feat/support-capture-client-error-in-xhr-requests
---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>
Co-authored-by: kholood <keassa@instabug.com>

fix: APM test cases

* fix: APM test cases

* fix test cases

* fix: PR comments

* fix: PR comments

* fix: PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @ahmedAlaaInstabug