Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): add W3C external trace attributes placeholder #1253

Merged
merged 4 commits into from
Jul 23, 2024
Merged

fix(android): add W3C external trace attributes placeholder #1253

merged 4 commits into from
Jul 23, 2024

Conversation

kholood-ea
Copy link
Contributor

@kholood-ea kholood-ea commented Jul 17, 2024 •
edited by a7medev
Loading

Description of the change

Add W3C External Trace Attributes Placeholder For Android

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-14970

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@kholood-ea kholood-ea requested a review from a7medev July 17, 2024 16:03
@kholood-ea kholood-ea self-assigned this Jul 17, 2024
a7medev
a7medev requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog item for the fix following our Changelog guidelines 🙏🏼

@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 17, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 98.9% ✅
Android 49.6% ✅
iOS 46.6% ✅

Generated by 🚫 dangerJS against 4b2d85a

@kholood-ea kholood-ea requested a review from a7medev July 17, 2024 16:39
@a7medev a7medev changed the title fix(android): add W3C External Trace Attributes placeholder fix(android): add W3C external trace attributes placeholder Jul 18, 2024
a7medev
a7medev approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Base automatically changed from fix/network-log-oom to dev July 18, 2024 12:58
@InstabugCI
Copy link
Collaborator

Your snapshot has been generated! 🚀

Installation

You can install the snapshot through NPM:

npm install https://github.com/Instabug/Instabug-React-Native\#snapshot/13.2.0-MOB-14970

or Yarn:

yarn add https://github.com/Instabug/Instabug-React-Native\#snapshot/13.2.0-MOB-14970

@kholood-ea kholood-ea merged commit 635cd47 into dev Jul 23, 2024
8 of 9 checks passed
@kholood-ea kholood-ea deleted the fix/android-network-logs branch July 23, 2024 07:15
mzelzoghbi pushed a commit that referenced this pull request Aug 4, 2024
@kholood-ea @mzelzoghbi
fix(android): APM network logging(#1253)
77ca0d4 
* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module
ahmedAlaaInstabug pushed a commit that referenced this pull request Sep 15, 2024
@kholood-ea @ahmedAlaaInstabug
fix(android): APM network logging(#1253)
61274de 
* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module
ahmedAlaaInstabug pushed a commit that referenced this pull request Sep 16, 2024
@kholood-ea @ahmedAlaaInstabug
fix(android): APM network logging(#1253)
b616240 
* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module
ahmedAlaaInstabug pushed a commit that referenced this pull request Sep 16, 2024
@kholood-ea @ahmedAlaaInstabug
fix(android): APM network logging(#1253)
cc8a2cc 
* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module
ahmedAlaaInstabug pushed a commit that referenced this pull request Sep 19, 2024
@kholood-ea @ahmedAlaaInstabug
fix(android): APM network logging(#1253)
0c77558 
* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module
ahmedAlaaInstabug added a commit that referenced this pull request Sep 19, 2024
@ahmedAlaaInstabug
fix: Replace Thrown Errors with Logs
d6e9f14 
sss
chore(ios): bump sdk to v13.1.0 (#1227)

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

chore(android): bump sdk to v13.1.1 (#1228)

* chore(android): bump android sdk v13.1.1

feat: enhance non-fatals support  (#1194)

* add non fatal api
---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

fix:  read env variable in sourcemap (#1232)

* fix sourcemap issue

* fix sourcemap issue

* fix sourcemap issue

* Update typo in CHANGELOG.md

---------

Co-authored-by: Andrew Amin <160974398+AndrewAminInstabug@users.noreply.github.com>

Release:v13.1.1 (#1231)

* release/v13.1.1

* Update CHANGELOG.md

Update CHANGELOG.md

chore(deps): bump @babel/traverse in /examples/default

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.24.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump follow-redirects from 1.15.2 to 1.15.6

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: cont work after logging

fix(android): change parameters used in inner class to final (#1239)

chore(android): bump sdk to v13.2.0 (#1245)

* chore(android): bump sdk to v13.2.0

* chore: update changelog

chore(ios): bump sdk to v13.2.0 (#1246)

release: v13.2.0 (#1247)

chore: resolve issues in changelog (#1249)

feat(example): add apm screen (#1141)

fix(android): resolve an OOM in network logs (#1244)

fix(android): APM network logging(#1253)

* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module

feat: export upload utils (#1252)

chore(example): remove flipper (#1259)

fix(android): pass network start time in microseconds (#1260)

* fix: network timestamp in android side

* fix: PR comments

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: support feature flags with variants (#1230)

Jira ID: MOB-14684

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

chore(android): bump android sdk to v13.3.0 (#1261)

chore(ios): bump sdk to v13.3.0 (#1262)

release: v13.3.0 (#1263)

chore: remove duplicate app flows entries in changelog (#1264)

chore: remove duplicate execution traces deprecation in changelog (#1265)

feat: navigation tracking support with expo router (#1270)

* feat: add screen tracker on screen change listener and tests

* feat (example): add screen change listener

chore: enhance expo router tracking support (#1272)

ci: generalize enterprise releases (#1275)

ci: run tests before enterprise releases (#1271)

ci: publish snapshots to npm (#1274)

fix: PR comments

fix(ios): network log empty response body (#1273)

fix: drop non-error objects when reporting errors (#1279)

* Fix: omitted non-error objects when logging errors

* ci: publish snapshots to npm (#1274)

* Fix: omitted non-error objects when logging errors

* fix: use warn instead of logs

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* fix: merge issues

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: capture client error in the network interceptor (#1257)

* feat/support-capture-client-error-in-xhr-requests
---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>
Co-authored-by: kholood <keassa@instabug.com>

fix: APM test cases
a7medev pushed a commit that referenced this pull request Nov 6, 2024
@ahmedAlaaInstabug
fix: replace thrown errors with logs (#1220)
1dc56b5 
* fix: Replace Thrown Errors with Logs

sss
chore(ios): bump sdk to v13.1.0 (#1227)

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

* chore(ios): bump ios sdk v13.1.0

chore(android): bump sdk to v13.1.1 (#1228)

* chore(android): bump android sdk v13.1.1

feat: enhance non-fatals support  (#1194)

* add non fatal api
---------

Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>

fix:  read env variable in sourcemap (#1232)

* fix sourcemap issue

* fix sourcemap issue

* fix sourcemap issue

* Update typo in CHANGELOG.md

---------

Co-authored-by: Andrew Amin <160974398+AndrewAminInstabug@users.noreply.github.com>

Release:v13.1.1 (#1231)

* release/v13.1.1

* Update CHANGELOG.md

Update CHANGELOG.md

chore(deps): bump @babel/traverse in /examples/default

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.24.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump follow-redirects from 1.15.2 to 1.15.6

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: cont work after logging

fix(android): change parameters used in inner class to final (#1239)

chore(android): bump sdk to v13.2.0 (#1245)

* chore(android): bump sdk to v13.2.0

* chore: update changelog

chore(ios): bump sdk to v13.2.0 (#1246)

release: v13.2.0 (#1247)

chore: resolve issues in changelog (#1249)

feat(example): add apm screen (#1141)

fix(android): resolve an OOM in network logs (#1244)

fix(android): APM network logging(#1253)

* fix(android): add W3C External Trace Attributes placeholder

* chore: add CHANGLOG

* chore: add CHANGLOG

* fix: remove ios sub module

feat: export upload utils (#1252)

chore(example): remove flipper (#1259)

fix(android): pass network start time in microseconds (#1260)

* fix: network timestamp in android side

* fix: PR comments

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: support feature flags with variants (#1230)

Jira ID: MOB-14684

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

chore(android): bump android sdk to v13.3.0 (#1261)

chore(ios): bump sdk to v13.3.0 (#1262)

release: v13.3.0 (#1263)

chore: remove duplicate app flows entries in changelog (#1264)

chore: remove duplicate execution traces deprecation in changelog (#1265)

feat: navigation tracking support with expo router (#1270)

* feat: add screen tracker on screen change listener and tests

* feat (example): add screen change listener

chore: enhance expo router tracking support (#1272)

ci: generalize enterprise releases (#1275)

ci: run tests before enterprise releases (#1271)

ci: publish snapshots to npm (#1274)

fix: PR comments

fix(ios): network log empty response body (#1273)

fix: drop non-error objects when reporting errors (#1279)

* Fix: omitted non-error objects when logging errors

* ci: publish snapshots to npm (#1274)

* Fix: omitted non-error objects when logging errors

* fix: use warn instead of logs

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

* fix: merge issues

---------

Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>

feat: capture client error in the network interceptor (#1257)

* feat/support-capture-client-error-in-xhr-requests
---------

Co-authored-by: Abdelhamid Nasser <38096011+abdelhamid-f-nasser@users.noreply.github.com>
Co-authored-by: Ahmed Elrefaey <68241710+a7medev@users.noreply.github.com>
Co-authored-by: kholood <keassa@instabug.com>

fix: APM test cases

* fix: APM test cases

* fix test cases

* fix: PR comments

* fix: PR comments

* fix: PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees

@kholood-ea kholood-ea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kholood-ea @InstabugCI @a7medev