Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cache and specialization to func decorator #877

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Adding cache and specialization to func decorator #877

merged 4 commits into from
Jan 23, 2023

Conversation

chudur-budur
Copy link
Contributor

@chudur-budur chudur-budur commented Jan 19, 2023 •
edited by diptorupd
Loading

Fixes #867 and #861.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur
Copy link
Contributor Author

@diptorupd

@diptorupd diptorupd marked this pull request as ready for review January 19, 2023 19:26
diptorupd
diptorupd reviewed Jan 19, 2023
View reviewed changes
notes.md Outdated Show resolved Hide resolved
diptorupd
diptorupd reviewed Jan 20, 2023
View reviewed changes
numba_dpex/decorators.py Outdated Show resolved Hide resolved
diptorupd
diptorupd reviewed Jan 20, 2023
View reviewed changes
numba_dpex/decorators.py Outdated Show resolved Hide resolved
diptorupd
diptorupd reviewed Jan 20, 2023
View reviewed changes
test-func-specialize.py Outdated Show resolved Hide resolved
@chudur-budur chudur-budur force-pushed the github-861 branch 2 times, most recently from 852a17d to 23e73ed Compare January 20, 2023 01:48
diptorupd
diptorupd reviewed Jan 20, 2023
View reviewed changes
numba_dpex/decorators.py Outdated Show resolved Hide resolved
@chudur-budur chudur-budur force-pushed the github-861 branch 2 times, most recently from be77154 to d0d61d6 Compare January 20, 2023 22:20
@diptorupd diptorupd force-pushed the github-861 branch 2 times, most recently from 8d8fc67 to 430fb18 Compare January 21, 2023 14:26
@diptorupd diptorupd mentioned this pull request Jan 21, 2023
Closed
@diptorupd diptorupd merged commit 8b3cf31 into IntelPython:main Jan 23, 2023
@diptorupd diptorupd deleted the github-861 branch January 23, 2023 14:49
github-actions bot added a commit that referenced this pull request Jan 23, 2023
@github-actions
Merge pull request #877 from chudur-budur/github-861
81e8c17 
Adding cache and specialization to func decorator 8b3cf31
@diptorupd diptorupd mentioned this pull request Jan 23, 2023
Closed
@fcharras fcharras mentioned this pull request Jan 29, 2023
Closed
@diptorupd diptorupd mentioned this pull request Feb 17, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't reuse dpex.func device functions with different signatures
2 participants
@chudur-budur @diptorupd