Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2649: Expose USB port in DeviceInfo service (ros2) #2655

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix #2649: Expose USB port in DeviceInfo service (ros2) #2655

merged 1 commit into from
Mar 14, 2023

Conversation

stwirth
Copy link
Contributor

@stwirth stwirth commented Mar 13, 2023

Same as #2654 but for the ROS2 driver.

@stwirth stwirth mentioned this pull request Mar 13, 2023
Closed
SamerKhshiboun
SamerKhshiboun approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamerKhshiboun
Copy link
Collaborator

@Nir-Az, I've tested the new functionality and it works good.

ros2 service call /camera/device_info realsense2_camera_msgs/srv/DeviceInfo

requester: making request: realsense2_camera_msgs.srv.DeviceInfo_Request()

response: realsense2_camera_msgs.srv.DeviceInfo_Response(device_name='intel_realsense_d435i', serial_number='912112073098', firmware_version='5.13.0.54', usb_type_descriptor='3.2', firmware_update_id='012345678901', sensors='stereo_module,rgb_camera,motion_module', physical_port='/sys/devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/video4linux/video0')

@Nir-Az Nir-Az merged commit 78eb9ae into IntelRealSense:ros2-development Mar 14, 2023
@Nir-Az
Copy link
Collaborator

Nir-Az commented Mar 14, 2023

@stwirth Thanks for you contribution!
Please note that we will only merge the ROS2 PR since ROS1 is no longer maintained.

@Nir-Az Nir-Az mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamerKhshiboun SamerKhshiboun SamerKhshiboun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stwirth @SamerKhshiboun @Nir-Az