Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cant translate /p help all #3906

Closed
2 tasks done
DevJoey opened this issue Jan 3, 2023 · 5 comments
Closed
2 tasks done

Cant translate /p help all #3906

DevJoey opened this issue Jan 3, 2023 · 5 comments
Labels
v7 related to, or targeted by, v7

Comments

@DevJoey
Copy link

DevJoey commented Jan 3, 2023 •
edited
Loading

Server Implementation

Paper

Server Version

1.19.2

Describe the bug

I want to translate this:
image
But there is nothin in the lang file.

To Reproduce

Try to translate!

Expected behaviour

It should be translateable

Screenshots / Videos

image

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/39b4ba1b8c8e4c05b170f671132ce825

PlotSquared Version

6.10.5-Premium

Checklist

Anything else?

No response
@DevJoey DevJoey added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Jan 3, 2023
@dordsor21
Copy link
Member

Duplicate of #3167

@dordsor21 dordsor21 marked this as a duplicate of #3167 Jan 6, 2023
@dordsor21 dordsor21 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
@DevJoey
Copy link
Author

DevJoey commented Jan 9, 2023

I have removed the duplicate! Please reopen! Thx

@SirYwell SirYwell reopened this Jan 9, 2023
@SirYwell SirYwell marked this as not a duplicate of #3167 Jan 9, 2023
@DevJoey DevJoey changed the title Cant translate /p help all and setting help header or footer to "" print empty line instead of hinding message Cant translate /p help all Jan 9, 2023
@NotMyFault
Copy link
Collaborator

Exists in

PlotSquared/Core/src/main/resources/lang/messages_en.json

Line 440 in 6a34a19

"help.help_display_all_commands": "<prefix><gray>Display all commands.</gray>",

NotMyFault added a commit that referenced this issue Jan 13, 2023
@NotMyFault
Fixes #3906 by fine-graining the help menu generation localization su…
1448d8d 
…pport
@NotMyFault
Copy link
Collaborator

Pushed 1448d8d to fine grain this behavior in v7.

@NotMyFault NotMyFault added v7 related to, or targeted by, v7 and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Jan 13, 2023
@DevJoey
Copy link
Author

DevJoey commented Jan 15, 2023 •
edited
Loading

Exists in

PlotSquared/Core/src/main/resources/lang/messages_en.json

Line 440 in 6a34a19

"help.help_display_all_commands": "<prefix><gray>Display all commands.</gray>",

This is not the message shown in /p help! You see there is a tag in front and a dot at the end! On the /p help message is no prefix and no dot! This message don't change the Description displayed in /p help

NotMyFault added a commit that referenced this issue Mar 6, 2023
@NotMyFault @PierreSchwang
@SirYwell @dordsor21
v7 is here (#3982)
f11f5f0 
* Update MiniMessage to 4.10.1 (#3617)

* chore!: bump MiniMessage to 4.10.1

BREAKING CHANGE: bumping MiniMessage and Adventure removes the adventure Template class and breaks the whole messaging system api wise

* chore: fix minimessage messages, fix circular method reference

* build: Update to Paper 1.18.2 (#3622)

build: Align MM and Adventure version

* Replace legacy color codes in flag examples (#3520)

* chore: Change maven group and artifact ID (#3632)

chore: Change maven group and artifact ID

* v7 is 7.0.0-SNAPSHOT

* build: Update bom

* Chore: General deprecations (#3660)

Address deprecations for removal throughout the plugin

* Address deprecations in queue/generation code (#3658)

* Update to new Spigot generation API (#3659)

* Address deprecations in queue/generation code

* Move to new generation API
 - Currently not working due to lack of biome-setting capability via BiomeProvider for flat worlds

* Any fixes to flat world biome setting will target 1.19

* Ensure compiled is actually set to true in BlockBucket

* Delegate to platformGenerator in deprecated generation method if applicable when using new generation methods (1.19)

* Re-add wrongly removed method

* Handle exceptions using logger

* We can simplify getting relative offset using floormod

* Replace many booleans with EnumSet

* Address comments, remove needless boolean return for populateChunk

* Ensure use of new generation methods only on 1.19 and above

* refactor: simplify timeout logic in uuid pipeline (#3760)

simplify timeout logic

* Fix compile errors

* Revert GAV changes

* Update javadoc links

* Start deployment of v7 snapshots

* Temporarily create javadocs for v7 snapshots

* Temporarily create javadocs for v7 snapshots

* Fixes #3919

* Fix relocation of informative annotations

* Drop HTTP4J (#3916)

* Fixes #3906 by fine-graining the help menu generation localization support

* Clean up merge

* *Actually clean up

* chore: Remove things marked as for removal (#3941)

* chore: Remove things marked as for removal

* Address feedback

Co-authored-by: Alexander Brandes <mc.cache@web.de>

* Resolved conflicts

* Cleanup deprecated methods

* Revert "Cleanup deprecated methods"

This reverts commit 26692d6.

* Record-inize methods (#3976)

* Delete unused HyperverseWorldManager file

* Migrate left over occurrences to enhanced switches (#3979)

* Migrate left-overs to enhanced switches

* More

* Cleanup deprecated methods (#3980)

* Perform code formatting according to editorconfig (#3981)

* Perform code reformatting

* Fix javadoc errors

* Don't format JSON files

---------

Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu>
Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
Co-authored-by: dordsor21 <dordsor21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v7 related to, or targeted by, v7
Projects
PlotSquared v7 roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dordsor21 @SirYwell @NotMyFault @DevJoey