Replace legacy color codes in flag examples #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dordsor21
approved these changes
Feb 26, 2022
NotMyFault
reviewed
Feb 26, 2022
I guess templates are currently resolved too by minimessage, I'm wondering if that's still the case in the latest version. If not, we can probably ignore it for now... |
|
This is indeed fixed in the MM version used in v7. Should we still merge it into v6 or retarget it instead? |
-0.9 from me, we can get it covered in v7, which is fine to me. |
SirYwell
force-pushed
the
fix/v6/legacy-color-codes
branch
from
88accd3 to
a188898
Compare
|
Retargeted and rebased (we'll just ignore the misleading branch name) |
NotMyFault
approved these changes
May 15, 2022
dordsor21
approved these changes
May 15, 2022
|
Thanks for your contribution! We will merge your PR within the next ~24 hours, as outlined in our PR review process. |
Citymonstret
approved these changes
May 16, 2022
NotMyFault
added a commit
that referenced
this pull request
Mar 6, 2023
* Update MiniMessage to 4.10.1 (#3617) * chore!: bump MiniMessage to 4.10.1 BREAKING CHANGE: bumping MiniMessage and Adventure removes the adventure Template class and breaks the whole messaging system api wise * chore: fix minimessage messages, fix circular method reference * build: Update to Paper 1.18.2 (#3622) build: Align MM and Adventure version * Replace legacy color codes in flag examples (#3520) * chore: Change maven group and artifact ID (#3632) chore: Change maven group and artifact ID * v7 is 7.0.0-SNAPSHOT * build: Update bom * Chore: General deprecations (#3660) Address deprecations for removal throughout the plugin * Address deprecations in queue/generation code (#3658) * Update to new Spigot generation API (#3659) * Address deprecations in queue/generation code * Move to new generation API - Currently not working due to lack of biome-setting capability via BiomeProvider for flat worlds * Any fixes to flat world biome setting will target 1.19 * Ensure compiled is actually set to true in BlockBucket * Delegate to platformGenerator in deprecated generation method if applicable when using new generation methods (1.19) * Re-add wrongly removed method * Handle exceptions using logger * We can simplify getting relative offset using floormod * Replace many booleans with EnumSet * Address comments, remove needless boolean return for populateChunk * Ensure use of new generation methods only on 1.19 and above * refactor: simplify timeout logic in uuid pipeline (#3760) simplify timeout logic * Fix compile errors * Revert GAV changes * Update javadoc links * Start deployment of v7 snapshots * Temporarily create javadocs for v7 snapshots * Temporarily create javadocs for v7 snapshots * Fixes #3919 * Fix relocation of informative annotations * Drop HTTP4J (#3916) * Fixes #3906 by fine-graining the help menu generation localization support * Clean up merge * *Actually clean up * chore: Remove things marked as for removal (#3941) * chore: Remove things marked as for removal * Address feedback Co-authored-by: Alexander Brandes <mc.cache@web.de> * Resolved conflicts * Cleanup deprecated methods * Revert "Cleanup deprecated methods" This reverts commit 26692d6. * Record-inize methods (#3976) * Delete unused HyperverseWorldManager file * Migrate left over occurrences to enhanced switches (#3979) * Migrate left-overs to enhanced switches * More * Cleanup deprecated methods (#3980) * Perform code formatting according to editorconfig (#3981) * Perform code reformatting * Fix javadoc errors * Don't format JSON files --------- Co-authored-by: Pierre Maurice Schwang <mail@pschwang.eu> Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com> Co-authored-by: dordsor21 <dordsor21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces two usages of legacy color codes in flag value examples.
Submitter Checklist